Skip to content

Commit 698c840

Browse files
committed
Merge PR #141 (Update .gitignore to avoid excluding util/Makefile* files)
This merge brings PR #141 (Update .gitignore to avoid excluding util/Makefile* files, by @yantosca) into the KPP 3.4.0 development stream. PR #141 does the following: 1. Updated the .gitignore file to avoid inadvertently excluding Makefiles (and other files) from the util folder. 2. Fixed an error in ./ci-pipelines/ci-cleanup-script.sh that caused the MCM C-I test folders to not be cleaned properly. Signed-off-by: Bob Yantosca <[email protected]>
2 parents 3550a56 + a7d6bf9 commit 698c840

File tree

3 files changed

+59
-58
lines changed

3 files changed

+59
-58
lines changed

.ci-pipelines/ci-cleanup-script.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ cwd=$(pwd -P)
1717
for this_test in ${GENERAL_TESTS}; do
1818
clean_ci_test_folder "${this_test}" "${this_test}" "${cwd}"
1919
done
20-
clean_ci_test_folder "${MCM_1}" "${MCM_1}" "${cwd}"
21-
clean_ci_test_folder "${MCM_2}" "mcm" "${cwd}"
20+
clean_ci_test_folder "${MCM_1}" mcm "${cwd}"
21+
clean_ci_test_folder "${MCM_2}" mcm "${cwd}"
2222

2323
# Remove any log files used to store C-I test results
2424
cd $cwd

.gitignore

Lines changed: 55 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,73 +1,72 @@
1+
# KPP .gitignore file
2+
#
3+
# For info on how .gitignore rules work, see:
14
# https://www.atlassian.com/git/tutorials/saving-changes/gitignore
25
# https://linuxize.com/post/gitignore-ignoring-files-in-git
36

4-
# temporary files:
5-
*.~*
6-
*~
7-
.\#*
8-
\#*
7+
# Keep empty directory for executables, but ignore its contents
8+
/bin/*
9+
10+
# Ignore temporary files everywhere
11+
**/*.~*
12+
**/*~
13+
**/.\#*
14+
**/\#*
915

10-
# files generated by bison:
16+
# Ignore files generated by bison (in src/)
1117
/src/lex.yy.c
1218
/src/y.tab.c
1319
/src/y.tab.h
1420

15-
# from compiler:
16-
*.mod
17-
*.o
18-
*.exe
21+
# Ignore files generated by the compiler (everywhere)
22+
**/*.mod
23+
**/*.o
24+
**/*.exe
1925

20-
# results from ci-tests:
26+
# Ignore files generated by C-I tests (in ci-tests/*)
27+
/ci-tests/**/*.dat
28+
/ci-tests/**/*.h
2129
/ci-tests/**/*.m
30+
/ci-tests/**/Makefile_*
2231
/ci-tests/**/*results*
23-
/ci-tests/**/*.exe
24-
/ci-tests/**/*.h
25-
/ci-tests/**/*.log
26-
/ci-tests/**/*.dat
2732

28-
# keep empty directory for executables, but not its contents:
29-
/bin/*
30-
!/bin/.gitkeep
31-
32-
# KPP-generated files:
33-
*_Function*
34-
*_Global*
35-
*_Hessian*
36-
*_HessianSP*
37-
*_Initialize*
38-
*_Integrator*
39-
*_Jacobian*
40-
*_JacobianSP*
41-
*_LinearAlgebra*
42-
*.log
43-
*_Main*
44-
*_mex_Fun*
45-
*_mex_Hessian*
46-
*_mex_Jac_SP*
47-
*_Model*
48-
*_Monitor*
49-
*_Parameters*
50-
*_Precision*
51-
*_Rates*
52-
*_Stoichiom*
53-
*_StoichiomSP*
54-
*_Util*
55-
Makefile_*
33+
# Ignore files generated by KPP (everywhere)
34+
**/*_Function*
35+
**/*_Global*
36+
**/*_Hessian*
37+
**/*_HessianSP*
38+
**/*_Initialize*
39+
**/*_Integrator*
40+
**/*_Jacobian*
41+
**/*_JacobianSP*
42+
**/*_LinearAlgebra*
43+
**/*.log
44+
**/*_Main*
45+
**/*_*ex_Fun*
46+
**/*_*ex_Hessian*
47+
**/*_*ex_Jac_SP*
48+
**/*_Model*
49+
**/*_Monitor*
50+
**/*_Parameters*
51+
**/*_Precision*
52+
**/*_Rates*
53+
**/*_Stoichiom*
54+
**/*_StoichiomSP*
55+
**/*_Util*
5656

57-
# LaTeX and BibTeX files:
58-
/manual/*.aux
59-
/manual/*.bbl
60-
/manual/*.blg
61-
/manual/*.log
62-
/manual/*.toc
63-
64-
# ReadTheDocs files
57+
# Ignore files generated by ReadTheDocs (in docs/build)
6558
docs/build/*
6659

67-
# are there any *.dat files to exclude?
68-
*.dat
69-
70-
# Other files/dirs to exclude
60+
# Ignore other files & folders
7161
*.pdf
72-
/examples/mcm*/__pycache__
62+
**/__pycache__
7363

64+
# IMPORTANT: Do not ignore these files!
65+
!/bin/.gitkeep
66+
!/docs/figures/*.pdf
67+
!/util/*.c
68+
!/util/*.f
69+
!/util/*.h
70+
!/util/*.f90
71+
!/util/*.m
72+
!/util/Makefile*

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121

2222
## Fixed
2323
- Moved the `which kpp` instruction to the end of the "Build the KPP executable" section in the installation guide on ReadTheDocs
24+
- Updated rules to ignore files in `.gitignore` and updated comments accordingly
25+
- Fixed a bug that prevented `.ci-pipelines/ci-cleanup-script.sh` from removing KPP-generated files for MCM mechanisms
2426

2527
### Removed
2628
- Removed C-I tests on Microsoft Azure Dev Pipelines

0 commit comments

Comments
 (0)