Skip to content

Conversation

jtran
Copy link

@jtran jtran commented Aug 5, 2025

@jtran
Copy link
Author

jtran commented Aug 29, 2025

One big unresolved question I’m aware of is: what is the minimum API surface that is still powerful enough to do all the things we want to do? I enumerated some of the current functions in the doc. But there are more things manipulating the AST that don’t use these functions that are scattered all around the codebase. I don’t know where they all are. deleteFromSelection is one that I know has been the source of some pain. There’s also all the current constraint stuff.

Question 2: Is the stuff generating new code going to use glorified string templates? I basically propose that. I imagine KclSource type being a thin wrapper around TS string. Now that the language is stable, it’s a possibility, when it wasn’t before. Is this acceptable? As an alternative, I could imagine some kind of builder API. But this sounds like more work that I’m not sure is worth it.

@jtran
Copy link
Author

jtran commented Aug 29, 2025

The hope is that we're writing all new code for sketch revamp, and at some point in the future, the old code will be deleted. So there wasn't much point in designing a refactoring API. Perhaps it could be used if the old code needs to stick around a long time. We can always re-open this if it comes to that.

@jtran jtran closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants