Custom chamfer profiles (#938)

* add ratio and angle to chamfer enum

* ratio is not a length unit

* add custom cut type

* improve comment

* add swap arg to Chamfer enum

* change ratio to second_length

* break out enum variants and imlp defualt

* make members public

* revert back to enum

* undo revert

* derive default

* remove default impl for CustomParams

Author: benjamaan476

modeling-cmds/src/shared.rs

@@ -11,17 +11,59 @@ use crate::{length_unit::LengthUnit, output::ExtrusionFaceInfo, units::UnitAngle
 
 mod point;
 
-/// What kind of cut to do
+/// Params required to perform a fillet cut of an edge.
 #[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize, JsonSchema, Default)]
 #[serde(rename_all = "snake_case")]
 #[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))]
 #[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))]
+pub struct FilletParams {
+    /// The second length affects the edge length of the second face of the cut. This will
+    /// cause the fillet to take on the shape of a conic section, instead of an arc.
+    pub second_length: Option<LengthUnit>,
+}
+
+/// Params required to perform a chamfer cut of an edge.
+#[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize, JsonSchema, Default)]
+#[serde(rename_all = "snake_case")]
+#[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))]
+#[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))]
+pub struct ChamferParams {
+    /// The second length affects the edge length of the second face of the cut.
+    pub second_length: Option<LengthUnit>,
+    /// The angle of the chamfer, default is 45deg.
+    pub angle: Option<Angle>,
+    /// If true, the second length or angle is applied to the other face of the cut.
+    pub swap: bool,
+}
+
+/// Params required to perform a custom profile cut of an edge.
+#[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize, JsonSchema)]
+#[serde(rename_all = "snake_case")]
+#[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))]
+#[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))]
+pub struct CustomParams {
+    /// The path that will be used for the custom profile.
+    pub path: Uuid,
+}
+
+/// What kind of cut to perform when cutting an edge.
+#[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize, JsonSchema)]
+#[serde(rename_all = "snake_case")]
+#[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))]
+#[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))]
 pub enum CutType {
     /// Round off an edge.
-    #[default]
-    Fillet,
+    Fillet(FilletParams),
     /// Cut away an edge.
-    Chamfer,
+    Chamfer(ChamferParams),
+    /// A custom cut profile.
+    Custom(CustomParams),
+}
+
+impl Default for CutType {
+    fn default() -> Self {
+        crate::shared::CutType::Fillet(FilletParams::default())
+    }
 }
 
 /// A rotation defined by an axis, origin of rotation, and an angle.