E2E tests: remove some, remove pixel checks and pixel-based clicks from some (#7960)

Author: franknoirot

e2e/playwright/boolean.spec.ts

@@ -47,6 +47,7 @@ test.describe('Point and click for boolean workflows', () => {
       }, file)
       await homePage.goToModelingScene()
       await scene.settled(cmdBar)
+      await toolbar.closePane('code')
 
       // Test coordinates for selection - these might need adjustment based on actual scene layout
       const cylinderPoint = { x: 592, y: 174 }
@@ -114,6 +115,8 @@ test.describe('Point and click for boolean workflows', () => {
 
         await cmdBar.submit()
         await scene.settled(cmdBar)
+        await editor.openPane()
+        await editor.scrollToText(operation.code)
         await editor.expectEditor.toContain(operation.code)
       })
 
@@ -126,7 +129,6 @@ test.describe('Point and click for boolean workflows', () => {
         await toolbar.closePane('feature-tree')
 
         // Expect changes in ft and code
-        await toolbar.openPane('code')
         await editor.expectEditor.not.toContain(operation.code)
         await expect(
           await toolbar.getFeatureTreeOperation(operationName, 0)

e2e/playwright/editor-tests.spec.ts

@@ -1331,7 +1331,7 @@ sketch001 = startSketchOn(XZ)
   test(
     `Can import a local OBJ file`,
     { tag: '@desktop' },
-    async ({ page, context }, testInfo) => {
+    async ({ page, context, scene, cmdBar }, testInfo) => {
       await context.folderSetupFn(async (dir) => {
         const bracketDir = join(dir, 'cube')
         await fsp.mkdir(bracketDir, { recursive: true })
@@ -1348,66 +1348,19 @@ sketch001 = startSketchOn(XZ)
       // Locators and constants
       const u = await getUtils(page)
       const projectLink = page.getByRole('link', { name: 'cube' })
-      const gizmo = page.locator('[aria-label*=gizmo]')
-      const resetCameraButton = page.getByRole('button', { name: 'Reset view' })
-      const locationToHaveColor = async (
-        position: { x: number; y: number },
-        color: [number, number, number]
-      ) => {
-        return u.getGreatestPixDiff(position, color)
-      }
-      const notTheOrigin = {
-        x: viewportSize.width * 0.55,
-        y: viewportSize.height * 0.3,
-      }
-      const origin = { x: viewportSize.width / 2, y: viewportSize.height / 2 }
       const errorIndicators = page.locator('.cm-lint-marker-error')
 
-      await test.step(`Open the empty file, see the default planes`, async () => {
+      await test.step(`Open the empty file`, async () => {
         await projectLink.click()
-        await u.waitForPageLoad()
-        await expect
-          .poll(
-            async () =>
-              locationToHaveColor(notTheOrigin, TEST_COLORS.DARK_MODE_PLANE_XZ),
-            {
-              timeout: 5000,
-              message: 'XZ plane color is visible',
-            }
-          )
-          .toBeLessThan(15)
+        await scene.settled(cmdBar)
       })
       await test.step(`Write the import function line`, async () => {
         await u.codeLocator.fill(`import 'cube.obj'\ncube`)
         await page.waitForTimeout(800)
       })
-      await test.step(`Reset the camera before checking`, async () => {
-        await u.doAndWaitForCmd(async () => {
-          await gizmo.click({ button: 'right' })
-          await resetCameraButton.click()
-        }, 'zoom_to_fit')
-      })
-      await test.step(`Verify that we see the imported geometry and no errors`, async () => {
+      await test.step(`Verify that we see no errors`, async () => {
+        await scene.settled(cmdBar)
         await expect(errorIndicators).toHaveCount(0)
-        await expect
-          .poll(
-            async () =>
-              locationToHaveColor(origin, TEST_COLORS.DARK_MODE_PLANE_XZ),
-            {
-              timeout: 3000,
-              message: 'Plane color should not be visible',
-            }
-          )
-          .toBeGreaterThan(15)
-        await expect
-          .poll(
-            async () => locationToHaveColor(origin, TEST_COLORS.DARK_MODE_BKGD),
-            {
-              timeout: 3000,
-              message: 'Background color should not be visible',
-            }
-          )
-          .toBeGreaterThan(15)
       })
     }
   )

e2e/playwright/file-tree.spec.ts

@@ -14,7 +14,7 @@ test.describe('integrations tests', () => {
   test(
     'Creating a new file or switching file while in sketchMode should exit sketchMode',
     { tag: '@desktop' },
-    async ({ page, context, homePage, scene, editor, toolbar, cmdBar }) => {
+    async ({ page, context, homePage, scene, toolbar, cmdBar }) => {
       await context.folderSetupFn(async (dir) => {
         const bracketDir = join(dir, 'test-sample')
         await fsp.mkdir(bracketDir, { recursive: true })
@@ -24,8 +24,6 @@ test.describe('integrations tests', () => {
         )
       })
 
-      const [clickObj] = scene.makeMouseHelpers(726, 272)
-
       await test.step('setup test', async () => {
         await homePage.expectState({
           projectCards: [
@@ -37,27 +35,15 @@ test.describe('integrations tests', () => {
           sortBy: 'last-modified-desc',
         })
         await homePage.openProject('test-sample')
-      })
-      await test.step('enter sketch mode', async () => {
         await scene.connectionEstablished()
         await scene.settled(cmdBar)
-        await clickObj()
-        await page.waitForTimeout(1000)
-        await scene.moveNoWhere()
-        await editor.expectState({
-          activeLines: [
-            '|>startProfile(at=[75.8,317.2])//[$startCapTag,$EndCapTag]',
-          ],
-          highlightedCode: '',
-          diagnostics: [],
-        })
-        await toolbar.editSketch()
-        await expect(toolbar.exitSketchBtn).toBeVisible()
       })
 
+      await toolbar.editSketch()
+
       const fileName = 'Untitled.kcl'
       await test.step('check sketch mode is exited when creating new file', async () => {
-        await toolbar.fileTreeBtn.click()
+        await toolbar.openPane('files')
         await toolbar.expectFileTreeState(['main.kcl'])
 
         await toolbar.createFile({ fileName, waitForToastToDisappear: true })
@@ -69,19 +55,7 @@ test.describe('integrations tests', () => {
       await test.step('setup for next assertion', async () => {
         await toolbar.openFile('main.kcl')
         await page.waitForTimeout(2000)
-        await clickObj()
-        await page.waitForTimeout(1000)
-        await scene.moveNoWhere()
-        await page.waitForTimeout(1000)
-        await editor.expectState({
-          activeLines: [
-            '|>startProfile(at=[75.8,317.2])//[$startCapTag,$EndCapTag]',
-          ],
-          highlightedCode: '',
-          diagnostics: [],
-        })
         await toolbar.editSketch()
-        await expect(toolbar.exitSketchBtn).toBeVisible()
         await toolbar.expectFileTreeState(['main.kcl', fileName])
       })
       await test.step('check sketch mode is exited when opening a different file', async () => {

e2e/playwright/fixtures/editorFixture.ts

@@ -20,7 +20,7 @@ export class EditorFixture {
   private paneButtonTestId = 'code-pane-button'
   private diagnosticsTooltip!: Locator
   private diagnosticsGutterIcon!: Locator
-  private codeContent!: Locator
+  public codeContent!: Locator
   public activeLine!: Locator
 
   constructor(page: Page) {