Skip to content

Commit 293b80c

Browse files
Use a more explicit state type for pausing, don't overload Disconnected (#8134)
* Use a more explicit state type for pausing, don't overload Disconnected * Remove arbitary timeout to jig error
1 parent 5c1a417 commit 293b80c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/lang/std/engineConnection.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export enum EngineConnectionStateType {
5656
ConnectionEstablished = 'connection-established',
5757
Disconnecting = 'disconnecting',
5858
Disconnected = 'disconnected',
59+
Paused = 'paused',
5960
}
6061

6162
export enum DisconnectingType {
@@ -206,6 +207,7 @@ export type EngineConnectionState =
206207
| State<EngineConnectionStateType.Connecting, ConnectingValue>
207208
| State<EngineConnectionStateType.ConnectionEstablished, void>
208209
| State<EngineConnectionStateType.Disconnecting, DisconnectingValue>
210+
| State<EngineConnectionStateType.Paused, void>
209211
| State<EngineConnectionStateType.Disconnected, void>
210212

211213
export enum EngineConnectionEvents {
@@ -1308,7 +1310,7 @@ class EngineConnection extends EventTarget {
13081310
)
13091311
} else {
13101312
this.state = {
1311-
type: EngineConnectionStateType.Disconnected,
1313+
type: EngineConnectionStateType.Paused,
13121314
}
13131315
}
13141316
this.triggeredStart = false

src/machines/engineStreamMachine.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,9 +260,7 @@ export const engineStreamMachine = setup({
260260

261261
let oldEngineConnection =
262262
rootContext.engineCommandManager.engineConnection
263-
setTimeout(() => {
264-
rootContext.engineCommandManager.tearDown({ idleMode: true })
265-
}, 1000)
263+
rootContext.engineCommandManager.tearDown({ idleMode: true })
266264

267265
let timeoutCheckId: ReturnType<typeof setTimeout>
268266
const timeoutEjectId = setTimeout(() => {
@@ -274,7 +272,7 @@ export const engineStreamMachine = setup({
274272
timeoutCheckId = setTimeout(() => {
275273
if (
276274
oldEngineConnection?.state?.type !==
277-
EngineConnectionStateType.Disconnected
275+
EngineConnectionStateType.Paused
278276
) {
279277
checkClosed()
280278
return

0 commit comments

Comments
 (0)