Codex unit tests for move

Author: franknoirot

src/preload.test.ts

@@ -0,0 +1,113 @@
+import path from 'node:path'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const fsPromisesMock = vi.hoisted(() => ({
+  rename: vi.fn(),
+  lstat: vi.fn(),
+  mkdir: vi.fn(),
+  cp: vi.fn(),
+  rm: vi.fn(),
+  access: vi.fn(),
+  readFile: vi.fn(),
+  writeFile: vi.fn(),
+  readdir: vi.fn(),
+  stat: vi.fn(),
+  constants: { R_OK: 4, W_OK: 2 },
+}))
+
+vi.mock('node:fs/promises', () => ({
+  default: fsPromisesMock,
+}))
+
+vi.mock('electron', () => ({
+  contextBridge: {
+    exposeInMainWorld: vi.fn(),
+  },
+  ipcRenderer: {
+    on: vi.fn(),
+    invoke: vi.fn(),
+    removeListener: vi.fn(),
+  },
+}))
+
+vi.mock('chokidar', () => ({
+  default: {
+    watch: vi.fn(() => ({
+      on: vi.fn(),
+      off: vi.fn(),
+    })),
+  },
+}))
+
+import { move } from '@src/preload'
+
+describe('move', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    fsPromisesMock.lstat.mockResolvedValue({
+      isDirectory: () => false,
+    })
+    fsPromisesMock.rename.mockResolvedValue(undefined)
+    fsPromisesMock.mkdir.mockResolvedValue(undefined)
+    fsPromisesMock.cp.mockResolvedValue(undefined)
+    fsPromisesMock.rm.mockResolvedValue(undefined)
+  })
+
+  it('renames directly when possible', async () => {
+    const result = await move('source.txt', 'dest.txt')
+
+    expect(result).toBeUndefined()
+    expect(fsPromisesMock.rename).toHaveBeenCalledTimes(1)
+    expect(fsPromisesMock.rename).toHaveBeenCalledWith('source.txt', 'dest.txt')
+    expect(fsPromisesMock.mkdir).not.toHaveBeenCalled()
+    expect(fsPromisesMock.cp).not.toHaveBeenCalled()
+    expect(fsPromisesMock.rm).not.toHaveBeenCalled()
+  })
+
+  it('creates destination directories when rename fails with ENOENT', async () => {
+    const destination = path.join('tmp', 'dir', 'file.txt')
+    fsPromisesMock.rename
+      .mockRejectedValueOnce({ code: 'ENOENT' })
+      .mockResolvedValueOnce(undefined)
+
+    await move('source.txt', destination)
+
+    expect(fsPromisesMock.mkdir).toHaveBeenCalledWith(path.join('tmp', 'dir'), {
+      recursive: true,
+    })
+    expect(fsPromisesMock.rename).toHaveBeenCalledTimes(2)
+    expect(fsPromisesMock.cp).not.toHaveBeenCalled()
+    expect(fsPromisesMock.rm).not.toHaveBeenCalled()
+  })
+
+  it('falls back to copy and delete when rename fails with EXDEV', async () => {
+    const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+    fsPromisesMock.rename.mockRejectedValueOnce({ code: 'EXDEV' })
+    fsPromisesMock.cp.mockResolvedValueOnce('copied')
+    fsPromisesMock.rm.mockResolvedValueOnce('removed')
+
+    const result = await move('source.txt', 'dest.txt')
+
+    expect(result).toEqual(['copied', 'removed'])
+    expect(fsPromisesMock.cp).toHaveBeenCalledWith('source.txt', 'dest.txt', {
+      recursive: true,
+    })
+    expect(fsPromisesMock.rm).toHaveBeenCalledWith('source.txt', {
+      recursive: true,
+    })
+    consoleSpy.mockRestore()
+  })
+
+  it('returns the error for non-EXDEV failures', async () => {
+    const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+    const error = { code: 'EACCES' }
+    fsPromisesMock.rename.mockRejectedValueOnce(error)
+
+    const result = await move('source.txt', 'dest.txt')
+
+    expect(result).toBe(error)
+    expect(fsPromisesMock.cp).not.toHaveBeenCalled()
+    expect(fsPromisesMock.rm).not.toHaveBeenCalled()
+    consoleSpy.mockRestore()
+  })
+})

src/preload.ts

@@ -123,7 +123,7 @@ const stat = (path: string) => {
  * creating any folders necessary to do so,
  * and falling back to copy-and-delete if rename fails.
  */
-async function move(source: string | URL, destination: string | URL) {
+export async function move(source: string | URL, destination: string | URL) {
   const isDir = (await fs.lstat(source)).isDirectory()
   return fs
     .rename(source, destination)