Skip to content

Commit 7c30a79

Browse files
authored
Remove the hard-coded disabled samples (#7940)
1 parent 595de3b commit 7c30a79

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

public/kcl-samples/manifest.json

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,16 @@
2323
"main.kcl"
2424
]
2525
},
26+
{
27+
"file": "main.kcl",
28+
"pathFromProjectDirectoryToFirstFile": "ball-joint-rod-end/main.kcl",
29+
"multipleFiles": false,
30+
"title": "ball joint rod end",
31+
"description": "A ball joint rod end is a mechanical linkage component that consists of a spherical ball housed within a socket, connected to a threaded rod, allowing rotational movement in multiple directions while providing a secure connection point between two parts of a mechanical system. Commonly used in steering systems and suspension components.",
32+
"files": [
33+
"main.kcl"
34+
]
35+
},
2636
{
2737
"file": "main.kcl",
2838
"pathFromProjectDirectoryToFirstFile": "bench/main.kcl",
@@ -447,6 +457,21 @@
447457
"main.kcl"
448458
]
449459
},
460+
{
461+
"file": "main.kcl",
462+
"pathFromProjectDirectoryToFirstFile": "multi-axis-robot/main.kcl",
463+
"multipleFiles": true,
464+
"title": "Robot Arm",
465+
"description": "A 4 axis robotic arm for industrial use. These machines can be used for assembly, packaging, organization of goods, and quality inspection processes",
466+
"files": [
467+
"globals.kcl",
468+
"main.kcl",
469+
"robot-arm-base.kcl",
470+
"robot-arm-j2.kcl",
471+
"robot-arm-j3.kcl",
472+
"robot-rotating-base.kcl"
473+
]
474+
},
450475
{
451476
"file": "main.kcl",
452477
"pathFromProjectDirectoryToFirstFile": "pdu-faceplate/main.kcl",

rust/kcl-lib/src/simulation_tests/kcl_samples.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ use walkdir::WalkDir;
1212

1313
use super::Test;
1414

15-
/// Some samples may be temporarily disabled.
16-
const DISABLED_SAMPLES: [&str; 2] = ["ball-joint-rod-end", "multi-axis-robot"];
17-
1815
lazy_static::lazy_static! {
1916
/// The directory containing the KCL samples source.
2017
static ref INPUTS_DIR: PathBuf = Path::new("../../public/kcl-samples").to_path_buf();
@@ -74,13 +71,6 @@ async fn unparse_test(test: &Test) {
7471

7572
#[kcl_directory_test_macro::test_all_dirs("../public/kcl-samples")]
7673
async fn kcl_test_execute(dir_name: &str, dir_path: &Path) {
77-
if DISABLED_SAMPLES.contains(&dir_name) {
78-
// NOTE: Do not remove this line. The error message is included in the
79-
// JUnit XML report for the Test Analysis Bot to post-process results
80-
// and determine whether the test should be marked as skipped.
81-
eprintln!("Skipping disabled sample: {}", dir_name);
82-
return;
83-
}
8474
let t = test(dir_name, dir_path.join("main.kcl"));
8575
super::execute_test(&t, true, true).await;
8676
}
@@ -307,7 +297,6 @@ fn generate_kcl_manifest(dir: &Path) -> Result<()> {
307297
.follow_links(true)
308298
.into_iter()
309299
.filter_map(|e| e.ok())
310-
.filter(|e| !DISABLED_SAMPLES.contains(&e.file_name().to_string_lossy().as_ref()))
311300
.collect();
312301

313302
// Sort directories by name for consistent ordering

0 commit comments

Comments
 (0)