Skip to content

Commit 882ca81

Browse files
committed
Keep only one px coordinate for sweepEdge selection in Fillet with large radius should update code even if engine fails
1 parent 0e49428 commit 882ca81

File tree

1 file changed

+5
-22
lines changed

1 file changed

+5
-22
lines changed

e2e/playwright/point-click.spec.ts

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1923,16 +1923,8 @@ extrude001 = extrude(profile001, length = 5)
19231923
const filletExpression = `fillet(radius = 1000, tags = [getCommonEdge(faces = [seg01, seg02])])`
19241924

19251925
// Locators
1926-
const edgeLocation = { x: 659, y: 313 }
1927-
const bodyLocation = { x: 594, y: 313 }
1928-
1929-
// Colors
1930-
const edgeColorWhite: [number, number, number] = [248, 248, 248]
1931-
const edgeColorYellow: [number, number, number] = [251, 251, 120] // Mac:B=251,251,90 Ubuntu:240,241,180, Windows:240,241,180
1932-
const backgroundColor: [number, number, number] = [30, 30, 30]
1933-
const bodyColor: [number, number, number] = [155, 155, 155]
1934-
const lowTolerance = 20
1935-
const highTolerance = 70
1926+
// TODO: find a way to select sweepEdges in a different way
1927+
const edgeLocation = { x: 649, y: 283 }
19361928

19371929
// Setup
19381930
await test.step(`Initial test setup`, async () => {
@@ -1941,28 +1933,19 @@ extrude001 = extrude(profile001, length = 5)
19411933
}, initialCode)
19421934
await page.setBodyDimensions({ width: 1000, height: 500 })
19431935
await homePage.goToModelingScene()
1944-
1945-
// verify modeling scene is loaded
1946-
await scene.expectPixelColor(backgroundColor, edgeLocation, lowTolerance)
1947-
1948-
// wait for stream to load
1949-
await scene.expectPixelColor(bodyColor, bodyLocation, highTolerance)
1936+
await scene.settled(cmdBar)
19501937
})
19511938

19521939
// Test
19531940
await test.step('Select edges and apply oversized fillet', async () => {
19541941
await test.step(`Select the edge`, async () => {
1955-
await scene.expectPixelColor(edgeColorWhite, edgeLocation, lowTolerance)
1942+
await toolbar.closePane('code')
1943+
await page.waitForTimeout(10000)
19561944
const [clickOnTheEdge] = scene.makeMouseHelpers(
19571945
edgeLocation.x,
19581946
edgeLocation.y
19591947
)
19601948
await clickOnTheEdge()
1961-
await scene.expectPixelColor(
1962-
edgeColorYellow,
1963-
edgeLocation,
1964-
highTolerance // Ubuntu color mismatch can require high tolerance
1965-
)
19661949
})
19671950

19681951
await test.step(`Apply fillet`, async () => {

0 commit comments

Comments
 (0)