KCL: Relax double-close error to warning (#7943)

Closing an already-closed sketch is now a warning, not an error.

Unfortunately this is tricky to add an autofix suggestion for, because
our current suggestion ("delete the close call")
would turn `|> close()` into `|>` with our current autofix implementation

Author: adamchalmers

rust/kcl-lib/src/std/sketch.rs

@@ -1233,10 +1233,14 @@ pub(crate) async fn inner_close(
     args: Args,
 ) -> Result<Sketch, KclError> {
     if sketch.is_closed {
-        return Err(KclError::new_semantic(KclErrorDetails::new(
-            "This sketch is already closed. Remove this unnecessary `close()` call".to_owned(),
-            vec![args.source_range],
-        )));
+        exec_state.warn(crate::CompilationError {
+            source_range: args.source_range,
+            message: "This sketch is already closed. Remove this unnecessary `close()` call".to_string(),
+            suggestion: None,
+            severity: crate::errors::Severity::Warning,
+            tag: crate::errors::Tag::Unnecessary,
+        });
+        return Ok(sketch);
     }
     let from = sketch.current_pen_position()?;
     let to = point_to_len_unit(sketch.start.get_from(), from.units);

rust/kcl-lib/tests/double_close/execution_error.snap

@@ -0,0 +1,5 @@
+---
+source: kcl-lib/src/simulation_tests.rs
+description: Execution success double_close.kcl
+---
+null

rust/kcl-lib/tests/double_close/execution_success.snap

@@ -2,4 +2,151 @@
 source: kcl-lib/src/simulation_tests.rs
 description: Variables in memory after executing double_close.kcl
 ---
-{}
+{
+  "shape": {
+    "type": "Sketch",
+    "value": {
+      "type": "Sketch",
+      "id": "[uuid]",
+      "paths": [
+        {
+          "__geoMeta": {
+            "id": "[uuid]",
+            "sourceRange": []
+          },
+          "from": [
+            -5.0,
+            -5.0
+          ],
+          "tag": null,
+          "to": [
+            5.0,
+            -5.0
+          ],
+          "type": "ToPoint",
+          "units": {
+            "type": "Mm"
+          }
+        },
+        {
+          "__geoMeta": {
+            "id": "[uuid]",
+            "sourceRange": []
+          },
+          "from": [
+            5.0,
+            -5.0
+          ],
+          "tag": null,
+          "to": [
+            5.0,
+            5.0
+          ],
+          "type": "ToPoint",
+          "units": {
+            "type": "Mm"
+          }
+        },
+        {
+          "__geoMeta": {
+            "id": "[uuid]",
+            "sourceRange": []
+          },
+          "from": [
+            5.0,
+            5.0
+          ],
+          "tag": null,
+          "to": [
+            -5.0,
+            5.0
+          ],
+          "type": "ToPoint",
+          "units": {
+            "type": "Mm"
+          }
+        },
+        {
+          "__geoMeta": {
+            "id": "[uuid]",
+            "sourceRange": []
+          },
+          "from": [
+            -5.0,
+            5.0
+          ],
+          "tag": null,
+          "to": [
+            -5.0,
+            -5.0
+          ],
+          "type": "ToPoint",
+          "units": {
+            "type": "Mm"
+          }
+        }
+      ],
+      "on": {
+        "artifactId": "[uuid]",
+        "id": "[uuid]",
+        "origin": {
+          "x": 0.0,
+          "y": 0.0,
+          "z": 0.0,
+          "units": {
+            "type": "Mm"
+          }
+        },
+        "type": "plane",
+        "value": "XY",
+        "xAxis": {
+          "x": 1.0,
+          "y": 0.0,
+          "z": 0.0,
+          "units": {
+            "type": "Unknown"
+          }
+        },
+        "yAxis": {
+          "x": 0.0,
+          "y": 1.0,
+          "z": 0.0,
+          "units": {
+            "type": "Unknown"
+          }
+        },
+        "zAxis": {
+          "x": 0.0,
+          "y": 0.0,
+          "z": 1.0,
+          "units": {
+            "type": "Unknown"
+          }
+        }
+      },
+      "start": {
+        "from": [
+          -5.0,
+          -5.0
+        ],
+        "to": [
+          -5.0,
+          -5.0
+        ],
+        "units": {
+          "type": "Mm"
+        },
+        "tag": null,
+        "__geoMeta": {
+          "id": "[uuid]",
+          "sourceRange": []
+        }
+      },
+      "artifactId": "[uuid]",
+      "originalId": "[uuid]",
+      "units": {
+        "type": "Mm"
+      }
+    }
+  }
+}