Skip to content

WIP: Add label function #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Add label function #8174

wants to merge 1 commit into from

Conversation

alteous
Copy link
Contributor

@alteous alteous commented Aug 29, 2025

No description provided.

@vercel Vercel
Copy link

vercel bot commented Aug 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Aug 29, 2025 1:11pm

@alteous
Copy link
Contributor Author

alteous commented Aug 29, 2025

It's not possible to distinguish edges from faces with this design. Compare these scenarios:

label(rectangleSegmentA001, text = "hello!") // labels the tagged edge
sketch002 = startSketchOn(profile001, face = rectangleSegmentA001) // sketches on the face formed by the tagged edge

Perhaps we could disambiguate these scenarios by the parameter name:

label(face = rectangleSegmentA00, text = "face label")
label(surface = rectangleSegmentA00, text = "surface label")
label(edge = rectangleSegmentA00, text = "edge label")
label(curve = rectangleSegmentA00, text = "curve label")

jtran
jtran reviewed Aug 29, 2025
View reviewed changes
rust/kcl-lib/std/prelude.kcl
) {}

/// Set a label.
@(impl = std_rust)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this as experimental until we settle on the final API.

Suggested change
@(impl = std_rust)
@(impl = std_rust, experimental = true)

You'll want to use @settings(experimentalFeatures = allow) at the top of your KCL file to be able to call it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtran jtran jtran left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alteous @jtran