Skip to content

Commit a76f444

Browse files
committed
Remove deprecated ‘doc-endnote’ role
1 parent 160e5d5 commit a76f444

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

index.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const clsx = require('clsx');
1010
// }
1111
const FOOTNOTE_MAP = {}
1212

13-
/**
13+
/**
1414
* @param {object} config - 11ty config
1515
* @param {object} [options] - Plugin options
1616
* @param {string} [baseClass] - Base CSS class for BEM
@@ -20,7 +20,7 @@ const FOOTNOTE_MAP = {}
2020
* @param {func} [backLinkLabel] - Footnote back link label generator
2121
*/
2222
module.exports = (config, options = {}) => {
23-
const {
23+
const {
2424
baseClass = 'Footnotes',
2525
title = 'Footnotes',
2626
titleId = 'footnotes-label',
@@ -29,11 +29,11 @@ module.exports = (config, options = {}) => {
2929
} = options;
3030
const bemClass = getBemClass(baseClass)
3131

32-
/**
32+
/**
3333
* @param {string} content - Footnote reference content
3434
* @param {string} id - Footnote id
3535
* @param {string} description - Actual footnote content
36-
*/
36+
*/
3737
function footnoteref(content, id, description) {
3838
const key = this.page.inputPath
3939
const footnote = { id, description }
@@ -76,7 +76,6 @@ module.exports = (config, options = {}) => {
7676
const listItemAttrs = attrs({
7777
id: `${footnote.id}-note`,
7878
class: clsx(bemClass('list-item'), classes.listItem),
79-
role: 'doc-endnote',
8079
})
8180
const backLinkAttrs = attrs({
8281
class: clsx(bemClass('back-link'), classes.backLink),

test.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ describe('The `footnotes` shortcode', () => {
8484
expect(listItem).not.toBeUndefined()
8585
expect(listItem.getAttribute('class')).toBe('Footnotes__list-item')
8686
expect(listItem.getAttribute('id')).toBe('foo-id-note')
87-
expect(listItem.getAttribute('role')).toBe('doc-endnote')
8887
expect(listItem.textContent).toBe('foo-footnote ↩')
8988
})
9089

@@ -152,7 +151,7 @@ describe('The `eleventy-plugin-footnotes` plugin', () => {
152151
})
153152

154153
it('should allow customizing class names for individual elements', () => {
155-
const { footnotes, footnoteref } = plugin(config, {
154+
const { footnotes, footnoteref } = plugin(config, {
156155
baseClass: 'Kitty',
157156
classes: {
158157
container: 'footer',
@@ -178,23 +177,23 @@ describe('The `eleventy-plugin-footnotes` plugin', () => {
178177
expect(containerClasses.contains('Kitty')).toBe(true)
179178
expect(containerClasses.contains('footer')).toBe(true)
180179
expect(containerClasses.length).toBe(2)
181-
180+
182181
expect(titleClasses.contains('Kitty__title')).toBe(true)
183182
expect(titleClasses.contains('title')).toBe(true)
184183
expect(titleClasses.length).toBe(2)
185-
184+
186185
expect(refClasses.contains('Kitty__ref')).toBe(true)
187186
expect(refClasses.contains('ref')).toBe(true)
188187
expect(refClasses.length).toBe(2)
189-
188+
190189
expect(listClasses.contains('Kitty__list')).toBe(true)
191190
expect(listClasses.contains('list')).toBe(true)
192191
expect(listClasses.length).toBe(2)
193-
192+
194193
expect(itemClasses.contains('Kitty__list-item')).toBe(true)
195194
expect(itemClasses.contains('item')).toBe(true)
196195
expect(itemClasses.length).toBe(2)
197-
196+
198197
expect(backLinkClasses.contains('Kitty__back-link')).toBe(true)
199198
expect(backLinkClasses.contains('back-link')).toBe(true)
200199
expect(backLinkClasses.length).toBe(2)

0 commit comments

Comments
 (0)