Fix broken build comments link (#3476)

index.php rows currently display an icon when comments have been left on
a build. That icon links to a broken AJAX route. This PR resolves the
issue by linking to the build summary page where the comments are
already displayed.

Author: williamjallen

app/Http/Controllers/BuildController.php

@@ -862,22 +862,6 @@ public function build_file(int $build_id, int $file_id): StreamedResponse
         }, $filename, $headers, 'inline');
     }
 
-    public function ajaxBuildNote(): View
-    {
-        $this->setBuildById((int) ($_GET['buildid'] ?? -1));
-        Gate::authorize('edit-project', $this->project);
-
-        $notes = DB::select('SELECT * FROM comments WHERE buildid=? ORDER BY timestamp ASC', [$this->build->Id]);
-        foreach ($notes as $note) {
-            /** @var User $user */
-            $user = User::where('id', (int) $note->userid)->first();
-            $note->user = $user;
-        }
-
-        return $this->view('build.note', 'Notes')
-            ->with('notes', $notes);
-    }
-
     public function apiViewBuildError(): JsonResponse
     {
         $pageTimer = new PageTimer();

phpstan-baseline.neon

@@ -693,7 +693,7 @@ parameters:
 		-
 			rawMessage: Cannot cast mixed to int.
 			identifier: cast.int
-			count: 12
+			count: 11
 			path: app/Http/Controllers/BuildController.php
 
 		-

resources/js/angular/views/partials/build.html

@@ -91,7 +91,7 @@
     <!-- Display the note icon -->
     <a class="cdash-link" name="Build Notes" id="buildnote_{{::build.id}}"
        ng-if="::build.buildnotes > 0"
-       ng-href="ajax/buildnote.php?buildid={{::build.id}}">
+       ng-href="builds/{{::build.id}}">
       <span class="glyphicon glyphicon-comment" style="color: #337ab7; margin-right: 4px;"></span>
     </a>
 

resources/views/build/note.blade.php

@@ -317,8 +317,6 @@
         return redirect('/sites', 301);
     });
 
-    Route::get('/ajax/buildnote.php', 'BuildController@ajaxBuildNote');
-
     Route::get('/projects/{projectId}/invitations/{invitationId}', ProjectInvitationController::class)
         ->whereNumber('projectId')
         ->whereNumber('invitationId');