Convert test details page backend to GraphQL (#3662)

This PR adds all the missing pieces required to render the test details
page based on data obtained via the GraphQL API, and switches the page
to use them. While this page also desperately needs some UI
improvements, the goal of this PR is simply to move away from the legacy
API endpoint. I'll follow up with a separate PR containing UI
improvements.

Author: williamjallen

app/Http/Controllers/TestDetailsController.php

@@ -30,6 +30,7 @@ public function details(int $id): View
         return $this->vue('test-details-page', 'Test Results', [
             'build-id' => $this->build->Id,
             'test-id' => $test->id,
+            'testing-day' => $this->date,
         ])
             ->with('previousUrl', $previousTest?->GetUrlForSelf())
             ->with('latestUrl', $latestTest?->GetUrlForSelf())

app/Models/TestImage.php

@@ -3,6 +3,7 @@
 namespace App\Models;
 
 use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
@@ -47,4 +48,20 @@ public function image(): BelongsTo
     {
         return $this->belongsTo(Image::class, 'imgid');
     }
+
+    /**
+     * @return Attribute<?string,void>
+     */
+    protected function url(): Attribute
+    {
+        return Attribute::make(
+            get: function (mixed $value, array $attributes): ?string {
+                if ($attributes['imgid'] === null || (int) $attributes['imgid'] === 0) {
+                    return null;
+                }
+
+                return url('/image/' . $attributes['imgid']);
+            },
+        );
+    }
 }

app/Policies/TestPolicy.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace App\Policies;
+
+use App\Models\Test;
+use App\Models\User;
+use Illuminate\Support\Facades\Gate;
+
+class TestPolicy
+{
+    public function view(?User $user, Test $test): bool
+    {
+        return Gate::check('view', $test->build);
+    }
+}

app/cdash/tests/CMakeLists.txt

@@ -208,6 +208,8 @@ add_feature_test_in_transaction(/Feature/GraphQL/ConfigureTypeTest)
 
 add_feature_test_in_transaction(/Feature/GraphQL/TestTypeTest)
 
+add_feature_test_in_transaction(/Feature/GraphQL/TestImageTypeTest)
+
 add_feature_test_in_transaction(/Feature/GraphQL/TestMeasurementTypeTest)
 
 add_feature_test_in_transaction(/Feature/GraphQL/NoteTypeTest)

graphql/schema.graphql

@@ -51,6 +51,12 @@ type Query {
     id: ID @eq
   ): Build @find @canResolved(ability: "view")
 
+  "Find a single test by ID."
+  test(
+    "Search by primary key."
+    id: ID @eq
+  ): Test @find @canResolved(ability: "view", action: RETURN_VALUE, returnValue: null)
+
   """
   Find a single site by ID.  All sites are currently public (although not necessarily
   the projects they contribute to).  In the future, the concept of "private sites"
@@ -930,6 +936,12 @@ type Test {
 
   runningTime: NonNegativeSeconds! @rename(attribute: "time") @filterable
 
+  "The average of recent running times for this test"
+  meanRunningTime: NonNegativeSeconds! @rename(attribute: "timemean") @filterable
+
+  "The standard deviation of recent running times for this test"
+  stdDevRunningTime: Float! @rename(attribute: "timestd") @filterable
+
   startTime: DateTimeTz @rename(attribute: "starttime") @filterable
 
   details: String! @filterable
@@ -944,6 +956,10 @@ type Test {
     filters: _ @filter
   ): [TestMeasurement!]! @hasMany @orderBy(column: "id", direction: DESC)
 
+  testImages(
+    filters: _ @filter
+  ): [TestImage!]! @hasMany(type: CONNECTION) @orderBy(column: "id", direction: DESC)
+
   labels(
     filters: _ @filter
   ): [Label!]! @belongsToMany(type: CONNECTION) @orderBy(column: "id", direction: DESC)
@@ -984,6 +1000,17 @@ type TestMeasurement {
 }
 
 
+"Test Measurement."
+type TestImage {
+  "Unique primary key."
+  id: ID!
+
+  role: String! @filterable
+
+  url: String
+}
+
+
 """
 Represents a command run during the build step.
 

phpstan-baseline.neon

@@ -5043,6 +5043,18 @@ parameters:
 			count: 1
 			path: app/Models/Test.php
 
+		-
+			rawMessage: Binary operation "." between '/image/' and mixed results in an error.
+			identifier: binaryOp.invalid
+			count: 1
+			path: app/Models/TestImage.php
+
+		-
+			rawMessage: Cannot cast mixed to int.
+			identifier: cast.int
+			count: 1
+			path: app/Models/TestImage.php
+
 		-
 			rawMessage: '''
 				Call to deprecated method forceRootUrl() of class Illuminate\Routing\UrlGenerator: