Merge pull request InsightSoftwareConsortium#5799 from blowekamp/fix_hdf5_mingw

Fix compilation issue with HDF5 and mingw.

Author: hjmjohnson

Modules/ThirdParty/HDF5/src/CMakeLists.txt

@@ -191,12 +191,6 @@ set(
   CACHE INTERNAL
   "Enable support for non-standard programming language features"
 )
-set(
-  HDF5_ENABLE_NONSTANDARD_FEATURE_FLOAT16
-  ON
-  CACHE INTERNAL
-  "Enable support for _Float16 C datatype"
-)
 set(
   HDF5_ENABLE_SUBFILING_VFD
   OFF
@@ -225,6 +219,11 @@ set(
   CACHE INTERNAL
   "Enable v1.14 API (v16, v18, v110, v112, v114)"
 )
+if(MINGW)
+  # vasprintf detection is unreliable on Windows/MinGW - hard-coded to 0
+  # See: https://github.com/HDFGroup/hdf5/issues/5885
+  set(H5_HAVE_VASPRINTF 0)
+endif()
 
 if(NOT BUILD_SHARED_LIBS)
   set(BUILD_STATIC_LIBS ON CACHE INTERNAL "Build Static Libraries")

Modules/ThirdParty/HDF5/src/itkhdf5/src/H5private.h

@@ -20,6 +20,11 @@
 #ifndef H5private_H
 #define H5private_H
 
+/* Define __STDC_WANT_IEC_60559_TYPES_EXT__ for _FloatN support, if available.
+ * Do that before including any other headers in case they include <float.h>
+ * implicitly. */
+#define __STDC_WANT_IEC_60559_TYPES_EXT__
+
 #include "H5public.h" /* Include Public Definitions    */
 
 #include <assert.h>
@@ -33,9 +38,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
-
-/* Define __STDC_WANT_IEC_60559_TYPES_EXT__ for _FloatN support, if available */
-#define __STDC_WANT_IEC_60559_TYPES_EXT__
 #include <float.h>
 #include <math.h>