Merge pull request InsightSoftwareConsortium#5667 from N-Dekker/BUG-issue-5666-Let-DataObjectError-override-Print

BUG: Let DataObjectError override `ExceptionObject::Print`

Author: thewtex

Modules/Core/Common/include/itkDataObject.h

@@ -90,8 +90,8 @@ class ITKCommon_EXPORT DataObjectError : public ExceptionObject
    * specific exception subtypes.  The default is to print out the
    * location where the exception was first thrown and any description
    * provided by the "thrower".   */
-  virtual void
-  PrintSelf(std::ostream & os, Indent indent) const;
+  void
+  Print(std::ostream & os) const override;
 
 private:
   DataObject * m_DataObject{ nullptr };
@@ -126,14 +126,6 @@ class ITKCommon_EXPORT InvalidRequestedRegionError : public DataObjectError
 
   /** \see LightObject::GetNameOfClass() */
   itkOverrideGetNameOfClassMacro(InvalidRequestedRegionError);
-
-protected:
-  /** Print exception information.  This method can be overridden by
-   * specific exception subtypes.  The default is to print out the
-   * location where the exception was first thrown and any description
-   * provided by the "thrower".   */
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 };
 
 /*----------------------------Data Object--------------------------------*/

Modules/Core/Common/src/itkDataObject.cxx

@@ -70,10 +70,12 @@ DataObjectError::GetDataObject() const noexcept
 
 
 void
-DataObjectError::PrintSelf(std::ostream & os, Indent indent) const
+DataObjectError::Print(std::ostream & os) const
 {
   ExceptionObject::Print(os);
 
+  const Indent indent{};
+
   os << indent << "Data object: ";
   if (m_DataObject)
   {
@@ -99,12 +101,6 @@ InvalidRequestedRegionError::InvalidRequestedRegionError(const InvalidRequestedR
 InvalidRequestedRegionError &
 InvalidRequestedRegionError::operator=(const InvalidRequestedRegionError &) noexcept = default;
 
-void
-InvalidRequestedRegionError::PrintSelf(std::ostream & os, Indent indent) const
-{
-  DataObjectError::PrintSelf(os, indent);
-}
-
 //----------------------------------------------------------------------------
 DataObject::DataObject()
   : m_SourceOutputName("")