Address code review feedback

- Remove print statements from tests
- Use np.zeros instead of np.random.randint
- Add image_size variable to avoid magic numbers
- Fix array dimension assertions (NumPy row-major vs ITK column-major)
- Improve comment explaining list unpacking logic in set_inputs

Co-authored-by: thewtex <[email protected]>

Author: Copilot

Wrapping/Generators/Python/Tests/test_imread_single_file_list.py

@@ -38,27 +38,27 @@ def test_imread_single_element_list():
 
     try:
         # Create and save a test image
-        arr = np.random.randint(0, 256, (10, 10), dtype=np.uint8)
+        image_size = (8, 10)
+        arr = np.zeros(image_size, dtype=np.uint8)
         image = itk.image_from_array(arr)
         itk.imwrite(image, filename)
 
         # Test 1: imread with a string (baseline - should always work)
         img_from_string = itk.imread(filename)
         assert img_from_string is not None
-        assert itk.size(img_from_string)[0] == 10
-        assert itk.size(img_from_string)[1] == 10
+        # NumPy shape (8, 10) becomes ITK size [10, 8] due to row/column-major ordering
+        assert itk.size(img_from_string)[0] == image_size[1]
+        assert itk.size(img_from_string)[1] == image_size[0]
 
         # Test 2: imread with a single-element list (the bug case)
         img_from_list = itk.imread([filename])
         assert img_from_list is not None
         # When reading as a series, dimension is increased by 1
         assert img_from_list.GetImageDimension() == 3
-        assert itk.size(img_from_list)[0] == 10
-        assert itk.size(img_from_list)[1] == 10
+        assert itk.size(img_from_list)[0] == image_size[1]
+        assert itk.size(img_from_list)[1] == image_size[0]
         assert itk.size(img_from_list)[2] == 1
 
-        print("✓ Test passed: imread works with single-element list")
-
     finally:
         # Cleanup
         if os.path.exists(filename):
@@ -76,7 +76,8 @@ def test_imread_multi_element_list():
 
     try:
         # Create and save test images
-        arr = np.random.randint(0, 256, (10, 10), dtype=np.uint8)
+        image_size = (8, 10)
+        arr = np.zeros(image_size, dtype=np.uint8)
         image = itk.image_from_array(arr)
         itk.imwrite(image, filename1)
         itk.imwrite(image, filename2)
@@ -86,12 +87,11 @@ def test_imread_multi_element_list():
         assert img_from_list is not None
         # When reading as a series, dimension is increased by 1
         assert img_from_list.GetImageDimension() == 3
-        assert itk.size(img_from_list)[0] == 10
-        assert itk.size(img_from_list)[1] == 10
+        # NumPy shape (8, 10) becomes ITK size [10, 8] due to row/column-major ordering
+        assert itk.size(img_from_list)[0] == image_size[1]
+        assert itk.size(img_from_list)[1] == image_size[0]
         assert itk.size(img_from_list)[2] == 2
 
-        print("✓ Test passed: imread works with multi-element list")
-
     finally:
         # Cleanup
         if os.path.exists(filename1):
@@ -105,4 +105,3 @@ def test_imread_multi_element_list():
 if __name__ == "__main__":
     test_imread_single_element_list()
     test_imread_multi_element_list()
-    print("\n✓ All imread list tests passed!")

Wrapping/Generators/Python/itk/support/extras.py

@@ -1681,7 +1681,11 @@ def SetInputs(self, *args, **kargs):
             import itk
 
             if type(value) in [list, tuple]:
-                # Special case for FileNames which expects a container, not unpacked arguments
+                # Special case for FileNames which expects a container, not unpacked arguments.
+                # Most ITK Set* methods that take multiple values expect them as separate arguments
+                # (e.g., SetSpacing(x, y, z)), so lists are unpacked with *.
+                # However, SetFileNames expects a single container argument (vector<string>),
+                # so we pass the list directly without unpacking.
                 if attribName == "FileNames":
                     attrib(value)
                 else: