HoloPlayCore is not found correctly

[mwestphal]

The findHoloPlayCore.cmake file does not help to find the HoloPlayCore.lib file in the right directory, has it may be in the bin directory.

[mathstuf]

I think adding PATHS bin to the find_library call may be enough, but testing would be necessary.

[jcfr]

To avoid maintaining our own Findxxx.cmake file, I suggest we create a HoloPlayCoreConfig.cmake and ask LookingGlass to distribute it with the SDK. This would greatly simplify the integration of the SDK and promote CMake best practices. What do you think?

…

On Thu, Oct 22, 2020, 9:27 AM Ben Boeckel ***@***.***> wrote: I think adding PATHS bin to the find_library call may be enough, but testing would be necessary. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABVPI7C2CTX2LETOWMSTQ3SMAXMFANCNFSM4S3GJ2AA> .

[mathstuf]

If that works, fine, but note that you'll effective minimum version will then be the version that finally shows up in (and works). Note that the FindHoloPlayCore breaks find_package(ParaView) when LookingGlass support is enabled today because this find module doesn't work without manual help to find the .lib on Windows.