Skip to content

Commit ab01aa0

Browse files
committed
feat: replace feedback button with keyboard shortcuts modal
Makes keyboard shortcuts more discoverable by placing them in the toolbar. Feedback link moved to About dialog useful links section.
1 parent 6531f9c commit ab01aa0

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

src/components/AboutBox.vue

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,16 @@
127127
https://github.com/Kitware/VolView/issues
128128
</a>
129129
</li>
130+
<li>
131+
<span>Submit feedback: </span>
132+
<a
133+
rel="noopener noreferrer"
134+
target="_blank"
135+
href="https://volview.kitware.com/feedback/"
136+
>
137+
https://volview.kitware.com/feedback/
138+
</a>
139+
</li>
130140
</ul>
131141
<h2>Version Info</h2>
132142
<v-divider class="mb-2" />

src/components/AppBar.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ import CloseableDialog from '@/src/components/CloseableDialog.vue';
55
import AboutBox from '@/src/components/AboutBox.vue';
66
import VolViewFullLogo from '@/src/components/icons/VolViewFullLogo.vue';
77
import VolViewLogo from '@/src/components/icons/VolViewLogo.vue';
8+
import { useKeyboardShortcutsStore } from '@/src/store/keyboard-shortcuts';
89
910
const emit = defineEmits(['click:left-menu']);
1011
1112
const { mobile } = useDisplay();
1213
const aboutBoxDialog = ref(false);
14+
const keyboardStore = useKeyboardShortcutsStore();
1315
</script>
1416

1517
<template>
@@ -24,12 +26,11 @@ const aboutBoxDialog = ref(false);
2426
icon
2527
:rounded="0"
2628
class="toolbar-button"
27-
href="https://volview.kitware.com/feedback/"
28-
target="_blank"
29+
@click="keyboardStore.settingsOpen = !keyboardStore.settingsOpen"
2930
>
30-
<v-icon icon="mdi-comment-question-outline"></v-icon>
31+
<v-icon icon="mdi-keyboard"></v-icon>
3132
<v-tooltip activator="parent" location="bottom">
32-
Ask Question/Submit Feedback
33+
Keyboard Shortcuts
3334
</v-tooltip>
3435
</v-btn>
3536
<v-btn

src/components/ControlsModal.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<closeable-dialog v-model="keyboardStore.settingsOpen">
2+
<closeable-dialog v-model="keyboardStore.settingsOpen" :close-offset-x="24">
33
<v-card class="pa-4">
44
<div class="text-h4 pb-2">View Controls</div>
55
<v-table>

0 commit comments

Comments
 (0)