Skip to content

Commit 01c7930

Browse files
Merge branch 'Kitware:master' into mpr-volume-mapper
2 parents 843a504 + 6e82cca commit 01c7930

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed

.eslintrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ const prettierConf = require('./prettier.config.js');
33

44
module.exports = {
55
parser: '@babel/eslint-parser',
6+
parserOptions: {
7+
babelOptions: {
8+
configFile: path.resolve(__dirname, '.babelrc.json'),
9+
},
10+
},
611
extends: ['airbnb/base', 'prettier'],
712
rules: {
813
'prettier/prettier': ['error', prettierConf],

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
lts/*

BREAKING_CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ In ShapeWidget:
88

99
RectangleWidget and EllipseWidget handles now scale up automatically.
1010

11+
## From 19.2 to 19.3
12+
13+
Node >=12 is required
14+
1115
## From 18.x to 19
1216

1317
vtkWidgetRepresentation.updateActorVisibility(...) lost the widgetVisibility parameter.

Sources/Interaction/Manipulators/VRButtonPanManipulator/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function vtkVRButtonPanManipulator(publicAPI, model) {
4343
const speed = data.gamepad.axes[1];
4444

4545
// 0.05 meters / frame movement
46-
const pscale = (speed * 0.05) / camera.getPhysicalScale();
46+
const pscale = speed * 0.05 * camera.getPhysicalScale();
4747

4848
// convert orientation to world coordinate direction
4949
const dir = camera.physicalOrientationToWorldDirection(data.orientation);

Sources/Interaction/Style/InteractorStyleTrackballCamera/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function vtkInteractorStyleTrackballCamera(publicAPI, model) {
9494
const speed = ed.gamepad.axes[1];
9595

9696
// 0.05 meters / frame movement
97-
const pscale = (speed * 0.05) / camera.getPhysicalScale();
97+
const pscale = speed * 0.05 * camera.getPhysicalScale();
9898

9999
// convert orientation to world coordinate direction
100100
const dir = camera.physicalOrientationToWorldDirection(ed.orientation);

0 commit comments

Comments
 (0)