perf(filter): reuse previous output in requestData

finetjul · finetjul · commit 42800b67c64f · 2025-08-29T16:35:28.000Z
This is consistent with VTK C++ and it improves the performances because newInstance() is called less often fix #3303
diff --git a/Sources/Filters/Core/Cutter/index.js b/Sources/Filters/Core/Cutter/index.js
@@ -314,7 +314,7 @@ function vtkCutter(publicAPI, model) {
       return;
     }
 
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
 
     dataSetCutter(input, output);
 
diff --git a/Sources/Filters/Core/PolyDataNormals/index.js b/Sources/Filters/Core/PolyDataNormals/index.js
@@ -98,7 +98,7 @@ function vtkPolyDataNormals(publicAPI, model) {
       return;
     }
 
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
 
     output.setPoints(input.getPoints());
     output.setVerts(input.getVerts());
diff --git a/Sources/Filters/Core/ThresholdPoints/index.js b/Sources/Filters/Core/ThresholdPoints/index.js
@@ -51,7 +51,7 @@ function vtkThresholdPoints(publicAPI, model) {
 
   publicAPI.requestData = (inData, outData) => {
     const input = inData[0];
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     outData[0] = output;
 
     if (model.criterias.length === 0) {
diff --git a/Sources/Filters/General/AppendPolyData/index.js b/Sources/Filters/General/AppendPolyData/index.js
@@ -46,7 +46,10 @@ function vtkAppendPolyData(publicAPI, model) {
     }
 
     // Allocate output
-    const output = vtkPolyData.newInstance();
+    const output =
+      outData[0] && inData[0] !== outData[0]
+        ? outData[0]
+        : vtkPolyData.newInstance();
 
     let numPts = 0;
     let pointType = 0;
diff --git a/Sources/Filters/General/Calculator/index.js b/Sources/Filters/General/Calculator/index.js
@@ -264,7 +264,8 @@ function vtkCalculator(publicAPI, model) {
 
     const arraySpec = model.formula.getArrays(inData);
 
-    const newDataSet = vtk({ vtkClass: inData[0].getClassName() });
+    const newDataSet =
+      outData[0] || vtk({ vtkClass: inData[0].getClassName() });
     newDataSet.shallowCopy(inData[0]);
     outData[0] = newDataSet;
 
diff --git a/Sources/Filters/General/ClipClosedSurface/index.js b/Sources/Filters/General/ClipClosedSurface/index.js
@@ -622,7 +622,7 @@ function vtkClipClosedSurface(publicAPI, model) {
   publicAPI.requestData = (inData, outData) => {
     // implement requestData
     const input = inData[0];
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     outData[0] = output;
 
     if (!input) {
diff --git a/Sources/Filters/General/ClosedPolyLineToSurfaceFilter/index.js b/Sources/Filters/General/ClosedPolyLineToSurfaceFilter/index.js
@@ -130,7 +130,7 @@ function vtkClosedPolyLineToSurfaceFilter(publicAPI, model) {
       return;
     }
 
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     output.shallowCopy(input);
 
     // Extract faces
diff --git a/Sources/Filters/General/ContourTriangulator/index.js b/Sources/Filters/General/ContourTriangulator/index.js
@@ -211,7 +211,7 @@ function vtkContourTriangulator(publicAPI, model) {
     // implement requestData
     const input = inData[0];
     // FIXME: do not instantiate a new polydata each time the filter is executed.
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     outData[0] = output;
 
     if (!input) {
diff --git a/Sources/Filters/General/ImageCropFilter/index.js b/Sources/Filters/General/ImageCropFilter/index.js
@@ -111,12 +111,11 @@ function vtkImageCropFilter(publicAPI, model) {
         index += slice.length;
       }
     }
-    const outImage = vtkImageData.newInstance({
-      extent: cropped,
-      origin: input.getOrigin(),
-      direction: input.getDirection(),
-      spacing: input.getSpacing(),
-    });
+    const outImage = outData[0] || vtkImageData.newInstance();
+    outImage.setExtent(cropped);
+    outImage.setOrigin(input.getOrigin());
+    outImage.setSpacing(input.getSpacing());
+    outImage.setDirection(input.getDirection());
 
     const croppedScalars = vtkDataArray.newInstance({
       name: scalars.getName(),
diff --git a/Sources/Filters/General/ImageMarchingCubes/index.js b/Sources/Filters/General/ImageMarchingCubes/index.js
@@ -341,7 +341,7 @@ function vtkImageMarchingCubes(publicAPI, model) {
     edgeLocator.initialize();
 
     // Update output
-    const polydata = vtkPolyData.newInstance();
+    const polydata = outData[0] || vtkPolyData.newInstance();
     polydata.getPoints().setData(new Float32Array(pBuffer), 3);
     polydata.getPolys().setData(new Uint32Array(tBuffer));
     if (model.computeNormals) {
diff --git a/Sources/Filters/General/ImageMarchingSquares/index.js b/Sources/Filters/General/ImageMarchingSquares/index.js
@@ -260,7 +260,7 @@ function vtkImageMarchingSquares(publicAPI, model) {
     }
 
     // Update output
-    const polydata = vtkPolyData.newInstance();
+    const polydata = outData[0] || vtkPolyData.newInstance();
     polydata.getPoints().setData(new Float32Array(points), 3);
     polydata.getLines().setData(new Uint32Array(lines));
     outData[0] = polydata;
diff --git a/Sources/Filters/General/ImageOutlineFilter/index.js b/Sources/Filters/General/ImageOutlineFilter/index.js
@@ -19,9 +19,8 @@ function vtkImageOutlineFilter(publicAPI, model) {
       return;
     }
 
-    const output = vtkImageData.newInstance(
-      input.get('spacing', 'origin', 'direction')
-    );
+    const output = outData[0] || vtkImageData.newInstance();
+    output.set(input.get('spacing', 'origin', 'direction'));
 
     const getIndex = (point, dims) =>
       point[0] + point[1] * dims[0] + point[2] * dims[0] * dims[1];
diff --git a/Sources/Filters/General/ImageSliceFilter/index.js b/Sources/Filters/General/ImageSliceFilter/index.js
@@ -45,7 +45,8 @@ function vtkImageSliceFilter(publicAPI, model) {
       values: sliceRawArray,
     });
 
-    const output = vtkImageData.newInstance(datasetDefinition);
+    const output = outData[0] || vtkImageData.newInstance();
+    output.set(datasetDefinition);
     output.getPointData().setScalars(sliceArray);
 
     outData[0] = output;
diff --git a/Sources/Filters/General/ImageStreamline/index.js b/Sources/Filters/General/ImageStreamline/index.js
@@ -262,7 +262,7 @@ function vtkImageStreamline(publicAPI, model) {
       offset2 += data[0].length;
     });
 
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     output.getPoints().setData(pointArray, 3);
     output.getLines().setData(cellArray);
 
diff --git a/Sources/Filters/General/LineFilter/index.js b/Sources/Filters/General/LineFilter/index.js
@@ -10,7 +10,7 @@ function vtkLineFilter(publicAPI, model) {
   model.classHierarchy.push('vtkLineFilter');
 
   publicAPI.requestData = (inData, outData) => {
-    const dataset = vtkPolyData.newInstance();
+    const dataset = outData[0] || vtkPolyData.newInstance();
 
     dataset.getPoints().setData(inData[0].getPoints().getData());
     dataset.getLines().setData(inData[0].getLines().getData());
diff --git a/Sources/Filters/General/MoleculeToRepresentation/index.js b/Sources/Filters/General/MoleculeToRepresentation/index.js
@@ -62,8 +62,8 @@ function vtkMoleculeToRepresentation(publicAPI, model) {
     }
 
     // output
-    const SphereData = vtkPolyData.newInstance();
-    const StickData = vtkPolyData.newInstance();
+    const SphereData = outData[0] || vtkPolyData.newInstance();
+    const StickData = outData[1] || vtkPolyData.newInstance();
 
     // Fetch from input molecule data
     let numPts = 0;
diff --git a/Sources/Filters/General/OutlineFilter/index.js b/Sources/Filters/General/OutlineFilter/index.js
@@ -49,7 +49,7 @@ function vtkOutlineFilter(publicAPI, model) {
     }
 
     const bounds = input.getBounds();
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
 
     output
       .getPoints()
diff --git a/Sources/Filters/General/ScalarToRGBA/index.js b/Sources/Filters/General/ScalarToRGBA/index.js
@@ -63,7 +63,8 @@ function vtkScalarToRGBA(publicAPI, model) {
       'origin',
       'direction'
     );
-    const output = vtkImageData.newInstance(datasetDefinition);
+    const output = outData[0] || vtkImageData.newInstance();
+    output.set(datasetDefinition);
     output.getPointData().setScalars(colorArray);
 
     outData[0] = output;
diff --git a/Sources/Filters/General/TriangleFilter/index.js b/Sources/Filters/General/TriangleFilter/index.js
@@ -80,7 +80,7 @@ function vtkTriangleFilter(publicAPI, model) {
       }
     }
 
-    const dataset = vtkPolyData.newInstance();
+    const dataset = outData[0] || vtkPolyData.newInstance();
     dataset
       .getPoints()
       .setData(macro.newTypedArrayFrom(pointsDataType, newPoints));
diff --git a/Sources/Filters/General/TubeFilter/index.js b/Sources/Filters/General/TubeFilter/index.js
@@ -605,7 +605,7 @@ function vtkTubeFilter(publicAPI, model) {
   publicAPI.requestData = (inData, outData) => {
     // implement requestData
     // pass through for now
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
     outData[0] = output;
 
     const input = inData[0];
diff --git a/Sources/Filters/General/WarpScalar/index.js b/Sources/Filters/General/WarpScalar/index.js
@@ -82,7 +82,7 @@ function vtkWarpScalar(publicAPI, model) {
         inPoints[ptOffset + 2] + model.scaleFactor * s * n[2];
     }
 
-    const newDataSet = vtk({ vtkClass: input.getClassName() });
+    const newDataSet = outData[0] || vtk({ vtkClass: input.getClassName() });
     newDataSet.shallowCopy(input);
     const points = vtkPoints.newInstance();
     points.setData(newPtsData, 3);
diff --git a/Sources/Filters/General/WindowedSincPolyDataFilter/index.js b/Sources/Filters/General/WindowedSincPolyDataFilter/index.js
@@ -624,7 +624,7 @@ function vtkWindowedSincPolyDataFilter(publicAPI, model) {
     if (!input) {
       return;
     }
-    const output = vtkPolyData.newInstance();
+    const output = outData[0] || vtkPolyData.newInstance();
 
     const outputPoints = publicAPI.vtkWindowedSincPolyDataFilterExecute(
       input.getPoints(),
diff --git a/Sources/Filters/Sources/Arrow2DSource/index.js b/Sources/Filters/Sources/Arrow2DSource/index.js
@@ -9,9 +9,7 @@ const { ShapeType } = Constants;
 // vtkArrow2DSource methods
 // ----------------------------------------------------------------------------
 
-function vtkStarSource(publicAPI, model) {
-  const dataset = vtkPolyData.newInstance();
-
+function vtkStarSource(publicAPI, model, dataset) {
   const points = macro.newTypedArray(model.pointType, 10 * 3);
   const edges = new Uint32Array(11);
   edges[0] = 10;
@@ -30,9 +28,7 @@ function vtkStarSource(publicAPI, model) {
   return dataset;
 }
 
-function vtk6PointsArrow(publicAPI, model) {
-  const dataset = vtkPolyData.newInstance();
-
+function vtk6PointsArrow(publicAPI, model, dataset) {
   const points = macro.newTypedArray(model.pointType, 6 * 3);
 
   const thickOp = model.height * 0.5 * model.thickness;
@@ -84,9 +80,7 @@ function vtk6PointsArrow(publicAPI, model) {
   return dataset;
 }
 
-function vtk4PointsArrow(publicAPI, model) {
-  const dataset = vtkPolyData.newInstance();
-
+function vtk4PointsArrow(publicAPI, model, dataset) {
   const points = macro.newTypedArray(model.pointType, 4 * 3);
 
   const thickOp = (model.height / 3) * model.thickness;
@@ -121,9 +115,7 @@ function vtk4PointsArrow(publicAPI, model) {
   return dataset;
 }
 
-function vtkTriangleSource(publicAPI, model) {
-  const dataset = vtkPolyData.newInstance();
-
+function vtkTriangleSource(publicAPI, model, dataset) {
   const points = macro.newTypedArray(model.pointType, 3 * 3);
 
   const baseOffsetOp = model.height * (1 - model.base);
@@ -157,7 +149,8 @@ function vtkArrow2DSource(publicAPI, model) {
   };
 
   publicAPI.requestData = (inData, outData) => {
-    outData[0] = shapeToSource[model.shape](publicAPI, model);
+    const dataset = outData[0] || vtkPolyData.newInstance();
+    outData[0] = shapeToSource[model.shape](publicAPI, model, dataset);
 
     vtkMatrixBuilder
       .buildFromRadian()
diff --git a/Sources/Filters/Sources/CircleSource/index.js b/Sources/Filters/Sources/CircleSource/index.js
@@ -16,7 +16,7 @@ function vtkCircleSource(publicAPI, model) {
       return;
     }
 
-    let dataset = outData[0];
+    const dataset = outData[0] || vtkPolyData.newInstance();
 
     // Points
     const points = macro.newTypedArray(model.pointType, model.resolution * 3);
@@ -39,7 +39,6 @@ function vtkCircleSource(publicAPI, model) {
     // connect endpoints
     edges[edges.length - 1] = edges[1];
 
-    dataset = vtkPolyData.newInstance();
     dataset.getPoints().setData(points, 3);
     if (model.lines) {
       dataset.getLines().setData(edges, 1);
diff --git a/Sources/Filters/Sources/ConcentricCylinderSource/index.js b/Sources/Filters/Sources/ConcentricCylinderSource/index.js
@@ -80,8 +80,6 @@ function vtkConcentricCylinderSource(publicAPI, model) {
     // Make sure we have consistency
     validateCellFields();
 
-    let dataset = outData[0];
-
     const numLayers = model.radius.length;
     const zRef = model.height / 2.0;
 
@@ -384,7 +382,7 @@ function vtkConcentricCylinderSource(publicAPI, model) {
       .rotateFromDirections([0, 0, 1], model.direction)
       .apply(points);
 
-    dataset = vtkPolyData.newInstance();
+    const dataset = outData[0] || vtkPolyData.newInstance();
     dataset.getPoints().setData(points, 3);
     dataset.getPolys().setData(polys, 1);
     dataset
diff --git a/Sources/Filters/Sources/ConeSource/example/index.js b/Sources/Filters/Sources/ConeSource/example/index.js
@@ -5,6 +5,7 @@ import '@kitware/vtk.js/Rendering/Profiles/Geometry';
 
 import vtkFullScreenRenderWindow from '@kitware/vtk.js/Rendering/Misc/FullScreenRenderWindow';
 import vtkActor from '@kitware/vtk.js/Rendering/Core/Actor';
+// import vtkPolyData from '@kitware/vtk.js/Common/DataModel/PolyData';
 import vtkConeSource from '@kitware/vtk.js/Filters/Sources/ConeSource';
 import vtkMapper from '@kitware/vtk.js/Rendering/Core/Mapper';
 
@@ -33,6 +34,23 @@ function createConePipeline() {
   mapper.setInputConnection(coneSource.getOutputPort());
 
   renderer.addActor(actor);
+
+  // const polyData = vtkPolyData.newInstance();
+  // const pointCount = Math.round(10000000 / 5);
+  // const points = new Float32Array(3 * pointCount);
+  // points.fill(1);
+  // polyData.getPoints().setData(points);
+  // polyData.getPoints().setRange({ min: 1, max: 1 }, 0);
+  // polyData.getPoints().setRange({ min: 1, max: 1 }, 1);
+  // polyData.getPoints().setRange({ min: 1, max: 1 }, 2);
+  // const polys = new Uint32Array(1000);
+  // polys.fill(1);
+  // polyData.getPolys().setData(polys);
+  // const mapper2 = vtkMapper.newInstance();
+  // mapper2.setInputData(polyData);
+  // const actor2 = vtkActor.newInstance();
+  // actor2.setMapper(mapper2);
+  // renderer.addActor(actor2);
   return { coneSource, mapper, actor };
 }
 
@@ -54,7 +72,7 @@ fullScreenRenderer.addController(controlPanel);
 ['height', 'radius', 'resolution'].forEach((propertyName) => {
   document.querySelector(`.${propertyName}`).addEventListener('input', (e) => {
     const value = Number(e.target.value);
-    pipelines[0].coneSource.set({ [propertyName]: value });
+    // pipelines[0].coneSource.set({ [propertyName]: value });
     pipelines[1].coneSource.set({ [propertyName]: value });
     renderWindow.render();
   });
diff --git a/Sources/Filters/Sources/ConeSource/index.js b/Sources/Filters/Sources/ConeSource/index.js
@@ -15,8 +15,6 @@ function vtkConeSource(publicAPI, model) {
       return;
     }
 
-    let dataset = outData[0];
-
     const angle = (2 * Math.PI) / model.resolution;
     const xbot = -model.height / 2.0;
     const numberOfPoints = model.resolution + 1;
@@ -68,7 +66,7 @@ function vtkConeSource(publicAPI, model) {
       .rotateFromDirections([1, 0, 0], model.direction)
       .apply(points);
 
-    dataset = vtkPolyData.newInstance();
+    const dataset = outData[0] || vtkPolyData.newInstance();
     dataset.getPoints().setData(points, 3);
     dataset.getPolys().setData(polys, 1);
 
diff --git a/Sources/Filters/Sources/CubeSource/index.js b/Sources/Filters/Sources/CubeSource/index.js
@@ -43,7 +43,7 @@ function vtkCubeSource(publicAPI, model) {
       return;
     }
 
-    const polyData = vtkPolyData.newInstance();
+    const polyData = outData[0] || vtkPolyData.newInstance();
     outData[0] = polyData;
 
     const numberOfPoints = 24;
diff --git a/Sources/Filters/Sources/Cursor3D/index.js b/Sources/Filters/Sources/Cursor3D/index.js
@@ -148,7 +148,7 @@ function vtkCursor3D(publicAPI, model) {
     if (numPts === 0) {
       return;
     }
-    const polyData = vtkPolyData.newInstance();
+    const polyData = outData[0] || vtkPolyData.newInstance();
     const newPts = vtkPoints.newInstance({ size: numPts * 3 });
     //  vtkCellArray is a supporting object that explicitly represents cell
     //  connectivity. The cell array structure is a raw integer list
diff --git a/Sources/Filters/Sources/CylinderSource/index.js b/Sources/Filters/Sources/CylinderSource/index.js
diff --git a/Sources/Filters/Sources/LineSource/index.js b/Sources/Filters/Sources/LineSource/index.js
diff --git a/Sources/Filters/Sources/PlaneSource/index.js b/Sources/Filters/Sources/PlaneSource/index.js
diff --git a/Sources/Filters/Sources/PointSource/index.js b/Sources/Filters/Sources/PointSource/index.js
diff --git a/Sources/Filters/Sources/SLICSource/index.js b/Sources/Filters/Sources/SLICSource/index.js
diff --git a/Sources/Filters/Sources/SphereSource/index.js b/Sources/Filters/Sources/SphereSource/index.js
diff --git a/Sources/Filters/Sources/ViewFinderSource/index.js b/Sources/Filters/Sources/ViewFinderSource/index.js
diff --git a/Sources/Filters/Texture/TextureMapToPlane/index.js b/Sources/Filters/Texture/TextureMapToPlane/index.js
diff --git a/Sources/Filters/Texture/TextureMapToSphere/index.js b/Sources/Filters/Texture/TextureMapToSphere/index.js

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ function vtkCutter(publicAPI, model) {`
`314`	`314`	`return;`
`315`	`315`	`}`
`316`	`316`
`317`		`- const output = vtkPolyData.newInstance();`
	`317`	`+ const output = outData[0] \|\| vtkPolyData.newInstance();`
`318`	`318`
`319`	`319`	`dataSetCutter(input, output);`
`320`	`320`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ function vtkPolyDataNormals(publicAPI, model) {`
`98`	`98`	`return;`
`99`	`99`	`}`
`100`	`100`
`101`		`- const output = vtkPolyData.newInstance();`
	`101`	`+ const output = outData[0] \|\| vtkPolyData.newInstance();`
`102`	`102`
`103`	`103`	`output.setPoints(input.getPoints());`
`104`	`104`	`output.setVerts(input.getVerts());`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ function vtkClosedPolyLineToSurfaceFilter(publicAPI, model) {`
`130`	`130`	`return;`
`131`	`131`	`}`
`132`	`132`
`133`		`- const output = vtkPolyData.newInstance();`
	`133`	`+ const output = outData[0] \|\| vtkPolyData.newInstance();`
`134`	`134`	`output.shallowCopy(input);`
`135`	`135`
`136`	`136`	`// Extract faces`