Skip to content

Commit 4fda109

Browse files
authored
Merge pull request #2143 from floryst/fix-setvisibility-retval
fix: setters should return bool
2 parents a81ef76 + a52f4c1 commit 4fda109

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Sources/Rendering/Core/CubeAxesActor/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,12 @@ function vtkCubeAxesActor(publicAPI, model) {
682682
publicAPI.update();
683683
});
684684

685-
publicAPI.setVisibility = macro.chain(
685+
const setVisibility = macro.chain(
686686
publicAPI.setVisibility,
687687
model.pixelActor.setVisibility,
688688
model.tmActor.setVisibility
689689
);
690+
publicAPI.setVisibility = (...args) => setVisibility(...args).some(Boolean);
690691

691692
publicAPI.setTickTextStyle = (tickStyle) => {
692693
model.tickTextStyle = { ...model.tickTextStyle, ...tickStyle };

Sources/Rendering/Core/ScalarBarActor/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -758,11 +758,12 @@ function vtkScalarBarActor(publicAPI, model) {
758758
publicAPI.modified();
759759
};
760760

761-
publicAPI.setVisibility = macro.chain(
761+
const setVisibility = macro.chain(
762762
publicAPI.setVisibility,
763763
model.barActor.setVisibility,
764764
model.tmActor.setVisibility
765765
);
766+
publicAPI.setVisibility = (...args) => setVisibility(...args).some(Boolean);
766767

767768
publicAPI.resetAutoLayoutToDefault = () => {
768769
model.autoLayout = defaultAutoLayout(publicAPI, model);

0 commit comments

Comments
 (0)