Skip to content

Commit 5193998

Browse files
PaulHaxfloryst
authored andcommitted
fix(AbstractPicker): model.pickFromList type is boolean
Init pickFromList to false not 0. Fix TypeScript defs.
1 parent efbaa80 commit 5193998

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

Sources/Rendering/Core/AbstractPicker/index.d.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { vtkObject } from '../../../interfaces';
22
import { Vector3 } from '../../../types';
3-
import vtkActor from '../Actor';
3+
import vtkProp3D from '../Prop3D';
44
import vtkRenderer from '../Renderer';
55

66
/**
@@ -10,8 +10,8 @@ export interface IAbstractPickerInitialValues {
1010
renderer?: vtkRenderer;
1111
selectionPoint?: Vector3;
1212
pickPosition?: Vector3;
13-
pickFromList?: number;
14-
pickList?: vtkActor[];
13+
pickFromList?: boolean;
14+
pickList?: vtkProp3D[];
1515
}
1616

1717
/**
@@ -20,15 +20,15 @@ export interface IAbstractPickerInitialValues {
2020
export interface vtkAbstractPicker extends vtkObject {
2121
/**
2222
*
23-
* @param {vtkActor} actor
23+
* @param {vtkProp3D} prop
2424
*/
25-
addPickList(actor: vtkActor): void;
25+
addPickList(prop: vtkProp3D): void;
2626

2727
/**
2828
*
29-
* @param {vtkActor} actor
29+
* @param {vtkProp3D} prop
3030
*/
31-
deletePickList(actor: vtkActor): void;
31+
deletePickList(prop: vtkProp3D): void;
3232

3333
/**
3434
*
@@ -38,7 +38,7 @@ export interface vtkAbstractPicker extends vtkObject {
3838
/**
3939
*
4040
*/
41-
getPickList(): boolean;
41+
getPickList(): vtkProp3D[];
4242

4343
/**
4444
* Get the picked position
@@ -82,17 +82,17 @@ export interface vtkAbstractPicker extends vtkObject {
8282

8383
/**
8484
*
85-
* @param {Number} pickFromList
86-
* @default 0
85+
* @param {Boolean} pickFromList
86+
* @default false
8787
*/
88-
setPickFromList(pickFromList: number): boolean;
88+
setPickFromList(pickFromList: boolean): boolean;
8989

9090
/**
9191
*
92-
* @param {vtkActor[]} pickList
92+
* @param {vtkProp3D[]} pickList
9393
* @default []
9494
*/
95-
setPickList(pickList: vtkActor[]): boolean;
95+
setPickList(pickList: vtkProp3D[]): boolean;
9696
}
9797

9898
/**

Sources/Rendering/Core/AbstractPicker/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const DEFAULT_VALUES = {
4444
renderer: null,
4545
selectionPoint: [0.0, 0.0, 0.0],
4646
pickPosition: [0.0, 0.0, 0.0],
47-
pickFromList: 0,
47+
pickFromList: false,
4848
pickList: [],
4949
};
5050

0 commit comments

Comments
 (0)