refactor(fullscreenrenderwindow, macro): refactor on fullscreenrenderwindow constructor

Refactor of fullscreenrenderwindow constructor so that the setXXX() methods of correesponding
properties are called when the fullScreenRenderWindow is instanciated (calling newInstance). In the
macro.js newInstance() method, the set() method is called in order that the setXXX() methods for
each entry of initial values is called if such methods exist. This is in order that side effects of
setters are taken into account when creating new objects and avoid having custom handling in extend
methods.

BREAKING CHANGE: In the extend method in fullScreenRenderWindow, the parameter initialValues is not
asked anymore. When extending this class, only default parameters defined in the
fullScreenRenderWindow will be passed.

Author: joannacirillo

Sources/Rendering/Misc/FullScreenRenderWindow/index.js

@@ -94,8 +94,14 @@ function vtkFullScreenRenderWindow(publicAPI, model) {
   model.interactor.initialize();
   model.interactor.bindEvents(model.container);
 
+  const superClass = { ...publicAPI };
+
   // Expose background
-  publicAPI.setBackground = model.renderer.setBackground;
+  publicAPI.setBackground = (background) => {
+    // Synchronize the setting of background from here to renderer
+    model.renderer.setBackground(background);
+    superClass.setBackground(background);
+  };
 
   publicAPI.removeController = () => {
     const el = model.controlContainer;
@@ -188,19 +194,22 @@ function vtkFullScreenRenderWindow(publicAPI, model) {
 // Object factory
 // ----------------------------------------------------------------------------
 
-const DEFAULT_VALUES = {
-  background: [0.32, 0.34, 0.43],
-  containerStyle: null,
-  controlPanelStyle: null,
-  listenWindowResize: true,
-  resizeCallback: null,
-  controllerVisibility: true,
-};
+function defaultValues(initialValues) {
+  return {
+    ...initialValues,
+    background: [0.32, 0.34, 0.43],
+    containerStyle: null,
+    controlPanelStyle: null,
+    listenWindowResize: true,
+    resizeCallback: null,
+    controllerVisibility: true,
+  };
+}
 
 // ----------------------------------------------------------------------------
 
 export function extend(publicAPI, model, initialValues = {}) {
-  Object.assign(model, DEFAULT_VALUES, initialValues);
+  Object.assign(model, defaultValues(initialValues));
 
   // Object methods
   macro.obj(publicAPI, model);
@@ -213,7 +222,7 @@ export function extend(publicAPI, model, initialValues = {}) {
     'container',
     'controlContainer',
   ]);
-
+  macro.setArray(publicAPI, model, ['background'], 3, 1.0);
   // Object specific methods
   vtkFullScreenRenderWindow(publicAPI, model);
 }

Sources/macros.js

@@ -972,6 +972,7 @@ export function newInstance(extend, className) {
     const model = {};
     const publicAPI = {};
     extend(publicAPI, model, initialValues);
+    publicAPI.set(initialValues);
 
     return Object.freeze(publicAPI);
   };