Merge pull request #2599 from Kitware/fix-classhierarchy-impl-usage

Fix classhierarchy impl usage

Author: floryst

Sources/Common/Core/ClassHierarchy/index.js

@@ -1,14 +1,12 @@
 /* eslint-disable prefer-rest-params */
 export default class ClassHierarchy extends Array {
   push() {
-    // using a for loop because a filter would trigger the garbage collector
-    const newArgs = [];
     for (let i = 0; i < arguments.length; i++) {
       if (!this.includes(arguments[i])) {
-        newArgs.push(arguments[i]);
+        super.push(arguments[i]);
       }
     }
 
-    return super.push(...newArgs);
+    return this.length;
   }
 }

Sources/macros.js

@@ -246,7 +246,11 @@ export function obj(publicAPI = {}, model = {}) {
   if (!('classHierarchy' in model)) {
     model.classHierarchy = new ClassHierarchy('vtkObject');
   } else if (!(model.classHierarchy instanceof ClassHierarchy)) {
-    model.classHierarchy = ClassHierarchy.from(model.classHierarchy);
+    const hierarchy = new ClassHierarchy();
+    for (let i = 0; i < model.classHierarchy.length; i++) {
+      hierarchy.push(model.classHierarchy[i]);
+    }
+    model.classHierarchy = hierarchy;
   }
 
   function off(index) {