Merge pull request #2381 from finetjul/2374-fix-widget-picking-with-invisible-handles

fix(widget): fix widget picking when substates are invisible

Author: floryst

Sources/Widgets/Representations/ArrowHandleRepresentation/index.js

@@ -251,17 +251,15 @@ function vtkArrowHandleRepresentation(publicAPI, model) {
     return orientationRotation;
   }
 
+  const superGetRepresentationStates = publicAPI.getRepresentationStates;
+  publicAPI.getRepresentationStates = (input = model.inputData[0]) =>
+    superGetRepresentationStates(input).filter(
+      (state) => state.getOrigin?.() && state.isVisible?.()
+    );
+
   publicAPI.requestDataInternal = (inData, outData) => {
     const { points, scale, color, direction } = model.internalArrays;
-    const list = publicAPI
-      .getRepresentationStates(inData[0])
-      .filter(
-        (state) =>
-          state.getOrigin &&
-          state.getOrigin() &&
-          state.isVisible &&
-          state.isVisible()
-      );
+    const list = publicAPI.getRepresentationStates(inData[0]);
     const totalCount = list.length;
 
     if (color.getNumberOfValues() !== totalCount) {

Sources/Widgets/Representations/CircleContextRepresentation/index.js

@@ -111,19 +111,16 @@ function vtkCircleContextRepresentation(publicAPI, model) {
     model.pipelines.circle.actor.getProperty().setOpacity(opacity);
   };
 
+  const superGetRepresentationStates = publicAPI.getRepresentationStates;
+  publicAPI.getRepresentationStates = (input = model.inputData[0]) =>
+    superGetRepresentationStates(input).filter(
+      (state) => state.getOrigin?.() && state.isVisible?.()
+    );
   // --------------------------------------------------------------------------
 
   publicAPI.requestData = (inData, outData) => {
     const { points, scale, color, direction } = model.internalArrays;
-    const list = publicAPI
-      .getRepresentationStates(inData[0])
-      .filter(
-        (state) =>
-          state.getOrigin &&
-          state.getOrigin() &&
-          state.isVisible &&
-          state.isVisible()
-      );
+    const list = publicAPI.getRepresentationStates(inData[0]);
     const totalCount = list.length;
 
     if (color.getNumberOfValues() !== totalCount) {

Sources/Widgets/Representations/CubeHandleRepresentation/index.js

@@ -55,19 +55,16 @@ function vtkCubeHandleRepresentation(publicAPI, model) {
 
   publicAPI.addActor(model.actor);
 
+  const superGetRepresentationStates = publicAPI.getRepresentationStates;
+  publicAPI.getRepresentationStates = (input = model.inputData[0]) =>
+    superGetRepresentationStates(input).filter(
+      (state) => state.getOrigin?.() && state.isVisible?.()
+    );
   // --------------------------------------------------------------------------
 
   publicAPI.requestData = (inData, outData) => {
     const { points, scale, color } = model.internalArrays;
-    const list = publicAPI
-      .getRepresentationStates(inData[0])
-      .filter(
-        (state) =>
-          state.getOrigin &&
-          state.getOrigin() &&
-          state.isVisible &&
-          state.isVisible()
-      );
+    const list = publicAPI.getRepresentationStates(inData[0]);
     const totalCount = list.length;
 
     if (color.getNumberOfValues() !== totalCount) {

Sources/Widgets/Representations/SphereContextRepresentation/index.js

@@ -63,17 +63,14 @@ function vtkSphereContextRepresentation(publicAPI, model) {
   publicAPI.setOpacity = (opacity) => {
     model.pipelines.circle.actor.getProperty().setOpacity(opacity);
   };
+  const superGetRepresentationStates = publicAPI.getRepresentationStates;
+  publicAPI.getRepresentationStates = (input = model.inputData[0]) =>
+    superGetRepresentationStates(input).filter(
+      (state) => state.getOrigin?.() && state.isVisible?.()
+    );
   publicAPI.requestData = (inData, outData) => {
     const { points, scale, color } = model.internalArrays;
-    const list = publicAPI
-      .getRepresentationStates(inData[0])
-      .filter(
-        (state) =>
-          state.getOrigin &&
-          state.getOrigin() &&
-          state.isVisible &&
-          state.isVisible()
-      );
+    const list = publicAPI.getRepresentationStates(inData[0]);
     const totalCount = list.length;
 
     if (color.getNumberOfValues() !== totalCount) {

Sources/Widgets/Representations/SphereHandleRepresentation/index.js

@@ -104,19 +104,17 @@ function vtkSphereHandleRepresentation(publicAPI, model) {
     model.displayMapper.setCallback(callback ? callbackProxy : null);
   };
 
+  const superGetRepresentationStates = publicAPI.getRepresentationStates;
+  publicAPI.getRepresentationStates = (input = model.inputData[0]) =>
+    superGetRepresentationStates(input).filter(
+      (state) => state.getOrigin?.() && state.isVisible?.()
+    );
+
   // --------------------------------------------------------------------------
 
   publicAPI.requestData = (inData, outData) => {
     const { points, scale, color } = model.internalArrays;
-    const list = publicAPI
-      .getRepresentationStates(inData[0])
-      .filter(
-        (state) =>
-          state.getOrigin &&
-          state.getOrigin() &&
-          state.isVisible &&
-          state.isVisible()
-      );
+    const list = publicAPI.getRepresentationStates(inData[0]);
     const totalCount = list.length;
 
     if (color.getNumberOfValues() !== totalCount) {