chore(WIP): debugging

Author: floryst

.github/workflows/build-test.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04]
-        node: [20, 22]
+        node: [22]
     name: ${{ matrix.os }} and node ${{ matrix.node }}
     steps:
       - uses: actions/checkout@v2
@@ -21,26 +21,26 @@ jobs:
         run: |
           npm ci
           sudo apt-get install xvfb
-      - name: Build
-        run: npm run build:release
-      - name: Archive build output
-        if: github.event_name != 'merge_group'
-        uses: actions/upload-artifact@v4
-        with:
-          name: build-results-${{ matrix.runs_on }}-node_${{ matrix.node }}
-          path: dist
-          retention-days: 15
-      - name: Validate generated typescript definitions
-        run: |
-          npx tsc -p tsconfig.esm-check.json
-          npx tsc -p tsconfig.umd-check.json
+      # - name: Build
+      #   run: npm run build:release
+      # - name: Archive build output
+      #   if: github.event_name != 'merge_group'
+      #   uses: actions/upload-artifact@v4
+      #   with:
+      #     name: build-results-${{ matrix.runs_on }}-node_${{ matrix.node }}
+      #     path: dist
+      #     retention-days: 15
+      # - name: Validate generated typescript definitions
+      #   run: |
+      #     npx tsc -p tsconfig.esm-check.json
+      #     npx tsc -p tsconfig.umd-check.json
       - name: Chrome and Firefox tests
-        run: xvfb-run --auto-servernum npm run test -- --browsers Chrome,Firefox
-      - name: Archive test results
-        if: github.event_name != 'merge_group' && (success() || failure())
-        uses: actions/upload-artifact@v4
-        continue-on-error: true
-        with:
-          name: test-results-${{ matrix.runs_on }}-node_${{ matrix.node }}
-          path: Utilities/TestResults/Test-Report.html
-          retention-days: 15
+        run: xvfb-run --auto-servernum npm run test -- --browsers Chrome
+      # - name: Archive test results
+      #   if: github.event_name != 'merge_group' && (success() || failure())
+      #   uses: actions/upload-artifact@v4
+      #   continue-on-error: true
+      #   with:
+      #     name: test-results-${{ matrix.runs_on }}-node_${{ matrix.node }}
+      #     path: Utilities/TestResults/Test-Report.html
+      #     retention-days: 15

Sources/Rendering/Core/HardwareSelector/test/testHardwareSelector.js

@@ -129,7 +129,7 @@ test('Test HardwareSelector', (tapeContext) => {
     })
   );
 
-  Promise.all(promises).then(() => {
+  return Promise.all(promises).then(() => {
     gc.releaseResources();
   });
 });

Sources/Rendering/Core/HardwareSelector/test/testHardwareSelectorGlyph.js

@@ -33,10 +33,10 @@ test('Test HardwareSelectorGlyph', (tapeContext) => {
   renderWindow.addRenderer(renderer);
   renderer.setBackground(0.32, 0.34, 0.43);
 
-  const planeSource = vtkPlaneSource.newInstance();
-  const simpleFilter = vtkCalculator.newInstance();
-  const mapper = vtkGlyph3DMapper.newInstance();
-  const actor = vtkActor.newInstance();
+  const planeSource = gc.registerResource(vtkPlaneSource.newInstance());
+  const simpleFilter = gc.registerResource(vtkCalculator.newInstance());
+  const mapper = gc.registerResource(vtkGlyph3DMapper.newInstance());
+  const actor = gc.registerResource(vtkActor.newInstance());
 
   simpleFilter.setFormula({
     getArrays: (inputDataSets) => ({
@@ -87,7 +87,7 @@ test('Test HardwareSelectorGlyph', (tapeContext) => {
 
   mapper.setInputConnection(simpleFilter.getOutputPort(), 0);
 
-  const coneSource = vtkConeSource.newInstance();
+  const coneSource = gc.registerResource(vtkConeSource.newInstance());
   coneSource.setResolution(12);
   mapper.setInputConnection(coneSource.getOutputPort(), 1);
   mapper.setOrientationArray('pressure');
@@ -107,7 +107,7 @@ test('Test HardwareSelectorGlyph', (tapeContext) => {
   const sel = glwindow.getSelector();
   sel.setFieldAssociation(FieldAssociations.FIELD_ASSOCIATION_POINTS);
 
-  sel.selectAsync(renderer, 200, 200, 250, 300).then((res) => {
+  return sel.selectAsync(renderer, 200, 200, 250, 300).then((res) => {
     const allGood = res.length === 7 && res[0].getProperties().prop === actor;
 
     tapeContext.ok(res.length === 7, 'Seven glyphs selected');

Sources/Rendering/Core/HardwareSelector/test/testHardwareSelectorManyCells.js

@@ -63,9 +63,13 @@ test('Test HardwareSelector', (tapeContext) => {
   glwindow.setSize(400, 400);
   renderWindow.addView(glwindow);
 
+  console.log(new Date());
+
   // Render to make set up the rendering pipeline
   renderWindow.render();
 
+  console.log(new Date());
+
   // Selector
   const selector = glwindow.getSelector();
   selector.setFieldAssociation(FieldAssociations.FIELD_ASSOCIATION_CELLS);
@@ -79,5 +83,6 @@ test('Test HardwareSelector', (tapeContext) => {
   const info = selector.getPixelInformation([200, 200], 0, [0, 0]);
   tapeContext.equal(info?.attributeID, numberOfVerts, 'Last triangle picked');
 
+  console.log(new Date());
   gc.releaseResources();
 });

Sources/Rendering/Core/HardwareSelector/test/testHardwareSelectorPoints.js

@@ -172,7 +172,7 @@ test.onlyIfWebGL('Test HardwareSelector Points', (tapeContext) => {
       tapeContext.ok(res[0].getProperties().attributeID === 2);
     })
   );
-  Promise.all(promises).then(() => {
+  return Promise.all(promises).then(() => {
     gc.releaseResources();
   });
 });

Sources/Rendering/Core/HardwareSelector/test/testHardwareSelectorSpeed.js

@@ -57,7 +57,7 @@ test('Test HardwareSelector', (tapeContext) => {
 
   console.time('first normal render');
   let previousTime = Date.now();
-  glwindow.captureNextImage().then(() => {
+  const promise = glwindow.captureNextImage().then(() => {
     const taTime = Date.now() - previousTime;
     console.timeEnd('first normal render');
 
@@ -88,4 +88,5 @@ test('Test HardwareSelector', (tapeContext) => {
     renderWindow.render();
   });
   renderWindow.render();
+  return promise;
 });

Sources/Testing/index.js

@@ -9,5 +9,15 @@ import './setupTestEnv';
 
 // webpack will include files that match the regex
 // '..' refers to the Sources/ dir
-const testsContext = require.context('..', true, /test[^/]*\.js$/);
+const testsContext = require.context(
+  '..',
+  true,
+  // /Rendering\/Core\/[A-M].*test[A-Za-z0-9]+\.js$/ // bad
+  // /Rendering\/Core\/[I-M].*test[A-Za-z0-9]+\.js$/ // good
+  // /Rendering\/Core\/[A-H].*test[A-Za-z0-9]+\.js$/ // bad
+  // /Rendering\/Core\/[F-H].*test[A-Za-z0-9]+\.js$/ // bad
+  // /Rendering\/Core\/[F-G].*test[A-Za-z0-9]+\.js$/ // good
+  // /Rendering\/Core\/Hard.*test[A-Za-z0-9]+\.js$/ // bad!
+  /Rendering\/Core\/Hard.*testHardwareSelectorManyCells\.js$/ // bad!
+);
 testsContext.keys().forEach(testsContext);

karma.conf.js

@@ -94,7 +94,7 @@ module.exports = function init(config) {
       },
     },
     browserNoActivityTimeout: 120000,
-    browserDisconnectTimeout: 10000,
+    browserDisconnectTimeout: 30000,
     browserDisconnectTolerance: 3,
 
     port: 9876,