-
Notifications
You must be signed in to change notification settings - Fork 32
Description
I have observed configure and builds issues when I have defined a Slicer custom application name which contains a space character. This is primarily a situation when the application name is a collection of words where is the desire is for them to be displayed to the user with a space rather than pushed together into a single long string. This makes things like desktop icon text easier to read, or start menu shortcuts easier to find because search can find separated words better than a substring word in a long string with no spaces.
cc: @sjh26 @jcfr , are there any apps that have successfully done this? I have only seen custom apps with names such as "SlicerSalt", "SlicerCAT", "CellLocator", "DentalSlicer" - all which do not utilize a space character between words.
For example, try to configure an application with name "3D Slicer" where there is a space character in the application name.
[1/12] project_name (SlicerCustomAppTemplate): 3D Slicer
[2/12] github_organization (Kitware): Kitware
[3/12] github_project (3D Slicer):
[4/12] org_domain (kitware.com):
[5/12] org_name (Kitware, Inc.):
[6/12] app_name (3D Slicer):
[7/12] bundle_identifier (com.kitware.3d slicer):
[8/12] app_version_major (0):
[9/12] app_version_minor (1):
[10/12] app_version_patch (0):
[11/12] app_description_summary (Customized version of Slicer):
[12/12] cdash_drop_site (open.cdash.org):
which generates files such as q3D SlicerAppMainWindow_p.h
class Q_3D SLICER_APP_EXPORT q3D SlicerAppMainWindowPrivate
: public qSlicerMainWindowPrivateOn the Windows platform, upon configuring I observe first error likely due to the mishandling of the space character in the application name being propagated by the cookiecutter action of this repo. This error does not occur if I set the application name as "3DSlicer" with no space.
CMake Error: Could not find cmake module file: CMakeDetermineSlicerCompiler.cmake
CMake Error: Could not find cmake module file: C:/D/3D Slicer-bin/CMakeFiles/3.31.8/CMakeSlicerCompiler.cmake
CMake Error at CMakeLists.txt:29 (project):
No CMAKE_Slicer_COMPILER could be found.
CMake Error: Could not find cmake module file: CMakeSlicerInformation.cmake
Configuring incomplete, errors occurred!
Upon resolving some space character issues, I ultimately still experience some issues with the space character in the application name propagating as a target name that fails in some ctkAppLauncher related configuration code.