fix(views): fix registration of builtin displayable managers

- Add vtkMRMLLinearTransformsDisplayableManager to handle linear
  transform widget creation.
- Add vtkMRMLColorLegendDisplayableManager to handle color legend
  display.
- Add back rendering for interactive tests

Author: Thibault-Pelletier

.github/workflows/test_and_merge.yml

@@ -70,10 +70,10 @@ jobs:
           pip install .[dev]
           playwright install
           playwright install-deps
-          pytest -s ./tests --cov=trame_slicer --cov-report=xml --cov-report=term-missing
+          pytest -s ./tests --cov=trame_slicer --cov-report=json --cov-report=term-missing
 
       - name: Upload Coverage to Codecov
         uses: codecov/codecov-action@v4
         with:
-          files: ./coverage.xml
+          files: ./coverage.json
           token: ${{ secrets.CODECOV_TOKEN }}

.gitignore

@@ -25,3 +25,6 @@ __pycache__
 *egg-info
 *pyc
 /dist
+
+coverage.*
+/.coverage

tests/conftest.py

@@ -52,8 +52,8 @@ def a_segment_id(a_segmentation_editor, an_active_segmentation):
 
 
 @pytest.fixture
-def a_view_factory():
-    return DirectViewFactory()
+def a_view_factory(render_interactive):
+    return DirectViewFactory(do_render_offscreen=not bool(render_interactive))
 
 
 @pytest.fixture

tests/direct_view_factory.py

@@ -21,6 +21,10 @@ class _View(Generic[AbstractViewChild]):
 
 
 class DirectViewFactory(IViewFactory):
+    def __init__(self, do_render_offscreen: bool):
+        super().__init__()
+        self._do_render_offscreen = do_render_offscreen
+
     def can_create_view(self, _view: ViewLayoutDefinition) -> bool:
         return True
 
@@ -31,25 +35,36 @@ def _create_view(
         app_logic: vtkMRMLApplicationLogic,
     ) -> V:
         if view.view_type == ViewType.SLICE_VIEW:
-            slice_view = SliceView(
+            slice_view = self._create_slice_view(app_logic, scene, view)
+            return _View(slice_view)
+        if view.view_type == ViewType.THREE_D_VIEW:
+            return _View(self._create_threed_view(app_logic, scene, view))
+        return None
+
+    def _create_threed_view(self, app_logic, scene, view: ViewLayoutDefinition) -> ThreeDView:
+        return self._update_offscreen_rendering(
+            ThreeDView(
                 scene,
                 app_logic,
                 view.singleton_tag,
                 scheduled_render_strategy=DirectRendering(),
             )
-            if view.properties.orientation:
-                slice_view.set_orientation(view.properties.orientation)
-            return _View(slice_view)
-        if view.view_type == ViewType.THREE_D_VIEW:
-            return _View(
-                ThreeDView(
-                    scene,
-                    app_logic,
-                    view.singleton_tag,
-                    scheduled_render_strategy=DirectRendering(),
-                )
-            )
-        return None
+        )
+
+    def _create_slice_view(self, app_logic, scene, view: ViewLayoutDefinition) -> SliceView:
+        slice_view = SliceView(
+            scene,
+            app_logic,
+            view.singleton_tag,
+            scheduled_render_strategy=DirectRendering(),
+        )
+        if view.properties.orientation:
+            slice_view.set_orientation(view.properties.orientation)
+        return self._update_offscreen_rendering(slice_view)
 
     def _get_slicer_view(self, view: V) -> AbstractViewChild:
         return view.slicer_view
+
+    def _update_offscreen_rendering(self, view: AbstractViewChild) -> AbstractViewChild:
+        view.render_window().SetOffScreenRendering(self._do_render_offscreen)
+        return view

tests/test_transform_node.py

@@ -0,0 +1,20 @@
+import pytest
+
+from tests.conftest import a_slice_view, a_threed_view
+
+
+@pytest.mark.parametrize("view", [a_threed_view, a_slice_view])
+def test_linear_transform_widget_can_be_displayed_in_views(view, request, a_slicer_app, render_interactive):
+    view = request.getfixturevalue(view.__name__)
+
+    transform_node = a_slicer_app.scene.AddNewNodeByClass("vtkMRMLLinearTransformNode")
+    assert transform_node
+
+    transform_node.CreateDefaultDisplayNodes()
+    display_node = transform_node.GetDisplayNode()
+    assert display_node
+
+    display_node.SetEditorVisibility(True)
+
+    if render_interactive:
+        view.start_interactor()

trame_slicer/views/slice_view.py

@@ -6,8 +6,10 @@
 import vtk
 from slicer import (
     vtkMRMLApplicationLogic,
+    vtkMRMLColorLegendDisplayableManager,
     vtkMRMLCrosshairDisplayableManager,
     vtkMRMLLayerDisplayableManager,
+    vtkMRMLLinearTransformsDisplayableManager,
     vtkMRMLMarkupsDisplayableManager,
     vtkMRMLModelSliceDisplayableManager,
     vtkMRMLOrientationMarkerDisplayableManager,
@@ -124,6 +126,8 @@ def __init__(
             vtkMRMLMarkupsDisplayableManager,
             vtkMRMLTransformsDisplayableManager2D,
             vtkMRMLLayerDisplayableManager,
+            vtkMRMLLinearTransformsDisplayableManager,
+            vtkMRMLColorLegendDisplayableManager,
         ]
         self._initialize_displayable_manager_group(vtkMRMLSliceViewDisplayableManagerFactory, app_logic, managers)
         self.name = name

trame_slicer/views/threed_view.py

@@ -7,10 +7,12 @@
     vtkMRMLApplicationLogic,
     vtkMRMLCameraDisplayableManager,
     vtkMRMLCameraNode,
+    vtkMRMLColorLegendDisplayableManager,
     vtkMRMLCrosshairDisplayableManager,
     vtkMRMLCrosshairDisplayableManager3D,
     vtkMRMLCrosshairNode,
     vtkMRMLLayerDisplayableManager,
+    vtkMRMLLinearTransformsDisplayableManager,
     vtkMRMLMarkupsDisplayableManager,
     vtkMRMLModelDisplayableManager,
     vtkMRMLOrientationMarkerDisplayableManager,
@@ -96,6 +98,8 @@ def __init__(
             vtkMRMLMarkupsDisplayableManager,
             vtkMRMLTransformsDisplayableManager3D,
             vtkMRMLLayerDisplayableManager,
+            vtkMRMLLinearTransformsDisplayableManager,
+            vtkMRMLColorLegendDisplayableManager,
         ]
 
         self._initialize_displayable_manager_group(vtkMRMLThreeDViewDisplayableManagerFactory, app_logic, managers)