minor bugfixes

Author: KlausC

src/fraction.jl

@@ -1,6 +1,7 @@
 
 # class constructors
 Frac(::Type{R}) where R<:Ring = Frac{R}
+Frac(::Type{<:ZZ{R}}) where R<:Integer = QQ{R}
 Frac(::Type{R}) where R<:Integer = QQ{R}
 
 # construction
@@ -48,7 +49,7 @@ Frac{T}(a::Base.Rational) where T = Frac{T}(T(a.num), T(a.den), NOCHECK)
 Frac{T}(a::Ring) where T = Frac{T}(T(a), one(T), NOCHECK)
 Frac(a::T) where T<:Ring = Frac{T}(a)
 Frac(a::T) where T<:Integer = Frac{ZZ{T}}(a)
-Frac(a::Rational{T}) where T<:Integer = Frac{ZZ{T}}(a)
+Frac(a::Rational{T}) where T<:Integer = Frac(ZZ{T})(a)
 Frac{T}(a::Integer, b::Integer) where T = Frac(T(a), T(b))
 function Frac(a::T, b::T) where T<:UnivariatePolynomial
     sh = ord(a) - ord(b)

src/promoteconvert.jl

@@ -50,5 +50,5 @@ end
 function (G::Type{<:Ring})(a::Any)
     B = basetype(G)
     # println("G = $G $(isconcretetype(G)) B = $B $(isconcretetype(B))")
-    isconcretetype(B) && !(a isa B) ? G(convert(B, a)) : throw(MethodError(G, Ref(a)))
+    isconcretetype(B) && !(a isa B) ? G(convert(B, a)) : throw(MethodError(G, (a,)))
 end

src/rationalcanonical.jl

@@ -76,11 +76,19 @@ Calculate the minimal polynomial `m_A` of a square matrix `A` over a ring.
 `m_A` is the minimum degree monic polynomial with `m_A(A) == 0`.
 """
 function minimal_polynomial(A::AbstractMatrix{R}) where R<:Ring
-    _minimal_polynomial(A)[1]
+    minimal_polynomial(A, category_trait(R))
+end
+
+function minimal_polynomial(A::AbstractMatrix{R}, ::Type{<:IntegralDomainTrait}) where R
+    ma = minimal_polynomial(Frac(R).(A))
+    UnivariatePolynomial{R}(ma)
 end
 
+function minimal_polynomial(A::AbstractMatrix{R}, ::Type{<:FieldTrait}) where R
+    _minimal_polynomial(A)[1]
+end
 # Implementation - also return a generating vector of stable space
-function _minimal_polynomial(A::AbstractMatrix{R}) where R<:Ring
+function _minimal_polynomial(A::AbstractMatrix{R}) where R
     n = checksquare(A)
     u = zeros(R, n)
     v = zeros(R, n)

src/univarpolynom.jl

@@ -103,6 +103,9 @@ promote_rule(::Type{UnivariatePolynomial{R,X}}, ::Type{S}) where {X,R,S<:Rationa
     UnivariatePolynomial{promote_type(R, S),X}
 
 (P::Type{<:UnivariatePolynomial{S}})(a::S) where {S} = P([a])
+function (P::Type{<:UnivariatePolynomial{S}})(a::UnivariatePolynomial{T,X}) where {S,T,X}
+    UnivariatePolynomial{S,X}(a.first, S.(a.coeff), NOCHECK)
+end
 (P::Type{<:UnivariatePolynomial{S}})(a::T) where {S,T<:RingInt} = P([S(a)])
 
 # convert coefficient vector to polynomial

src/zz.jl

@@ -21,7 +21,7 @@ function ZZ{T}(a::Union{QQ{T},Frac{ZZ{T}}}) where T
     a.den != 1 && throw(InexactError(:ZZ, ZZ{T}, a))
     ZZ(a.num)
 end
-ZZ(a::Union{QQ{T},Frac{ZZ{T}}}) where T = ZZ{T}(a)
+#ZZ(a::Union{QQ{T},Frac{ZZ{T}}}) where T = ZZ{T}(a)
 ZZ{S}(a::Union{QQ{T},Frac{ZZ{T}}}) where {S,T} = ZZ(promote_type(S,T)(a))
 
 # promotion and conversion

test/enumerations.jl

@@ -131,9 +131,9 @@ end
     @test iroot(196, 65) == 1
 end
 
-@testset "oftype" begin
+@testset "ofindex" begin
     P = ZZ{BigInt}[:x]
-    A = oftype(big(10)^1000, P)
+    A = ofindex(big(10)^1000, P)
     @test deg(A) > 1000
 end
 

test/rationalcanonical.jl

@@ -4,6 +4,7 @@ using Test
 using CommutativeRings
 using LinearAlgebra
 
+Z = ZZ{BigInt}
 Q = QQ{BigInt}
 #! format: off
 tm = [
@@ -39,6 +40,7 @@ push!(tm, [A A; -A A])
     @test rem(characteristic_polynomial(A), ma) == 0
     B = CommutativeRings.axspace(A, xa, n)
     @test A * B == B * ca
+    @test minimal_polynomial(Z.(A)) == ma
 end
 
 @testset "rational normal form test $i" for (i, A) in enumerate(tm)

test/zzmod.jl

@@ -148,10 +148,10 @@ end
     @test CommutativeRings._unsigned(big"-1") == big"-1"
 end
 
-@testset "promotion moduli not supported" begin
+@testset "promotion of moduli not supported" begin
     a = (ZZ / 12)(5)
     b = (ZZ / 21)(3)
-    @test_throws a + b isa ZZ / 3
+    @test_throws Exception a + b isa ZZ / 3
 end
 
 @testset "generator of ZZmod" begin