Improve uninstall list load error handling#895
Open
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Open
Improve uninstall list load error handling#895breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
.bculuninstall list loading more robust and improves the error shown when loading fails.Changes
Why
Users currently get generic errors like
There is an error in XML document (0, 0)when opening some uninstall list files. This change makes common failure modes easier to diagnose and avoids failing on benign leading BOM/whitespace cases.Closes #816