Extend issue comments to latest API changes, add some functional tests for it.

Author: stloyd

lib/Github/Api/Issue/Comments.php

@@ -11,6 +11,28 @@
  */
 class Comments extends AbstractApi
 {
+    public function configure($bodyType = null)
+    {
+        switch ($bodyType) {
+            case 'raw':
+                $header = sprintf('Accept: application/vnd.github.%s.raw+json', $this->client->getOption('api_version'));
+                break;
+
+            case 'text':
+                $header = sprintf('Accept: application/vnd.github.%s.text+json', $this->client->getOption('api_version'));
+                break;
+
+            case 'html':
+                $header = sprintf('Accept: application/vnd.github.%s.html+json', $this->client->getOption('api_version'));
+                break;
+
+            default:
+                $header = sprintf('Accept: application/vnd.github.%s.full+json', $this->client->getOption('api_version'));
+        }
+
+        $this->client->setHeaders(array($header));
+    }
+
     public function all($username, $repository, $issue, $page = 1)
     {
         return $this->get('repos/'.urlencode($username).'/'.urlencode($repository).'/issues/'.urlencode($issue).'/comments', array(

test/Github/Tests/Functional/IssueCommentTest.php

@@ -0,0 +1,102 @@
+<?php
+
+namespace Github\Tests\Functional;
+
+class IssueCommentTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function shouldRetrieveCommentsForIssue()
+    {
+        $username = 'KnpLabs';
+        $repo     = 'php-github-api';
+        $issue    = 13;
+
+        $comments = $this->client->api('issue')->comments()->all($username, $repo, $issue);
+        $comment  = array_pop($comments);
+
+        $this->assertArrayHasKey('id', $comment);
+        $this->assertArrayHasKey('url', $comment);
+        $this->assertArrayHasKey('body', $comment);
+        $this->assertArrayHasKey('user', $comment);
+        $this->assertArrayHasKey('created_at', $comment);
+        $this->assertArrayHasKey('updated_at', $comment);
+
+        return $comment['id'];
+    }
+
+    /**
+     * @test
+     * @depends shouldRetrieveCommentsForIssue
+     */
+    public function shouldRetrieveSingleComment($commentId)
+    {
+        $username = 'KnpLabs';
+        $repo     = 'php-github-api';
+
+        $comment = $this->client->api('issue')->comments()->show($username, $repo, $commentId);
+
+        $this->assertArrayHasKey('id', $comment);
+        $this->assertArrayHasKey('url', $comment);
+        $this->assertArrayHasKey('body', $comment);
+        $this->assertArrayHasKey('user', $comment);
+        $this->assertArrayHasKey('created_at', $comment);
+        $this->assertArrayHasKey('updated_at', $comment);
+    }
+
+    /**
+     * @test
+     */
+    public function shouldCreateCommentForIssue()
+    {
+        $username = 'KnpLabs';
+        $repo     = 'php-github-api';
+        $issue    = 13;
+        $params   = array('body' => '%');
+
+        $comment = $this->client->api('issue')->comments()->create($username, $repo, $issue, $params);
+
+        $this->assertArrayHasKey('id', $comment);
+        $this->assertArrayHasKey('url', $comment);
+        $this->assertArrayHasKey('body', $comment);
+        $this->assertArrayHasKey('user', $comment);
+        $this->assertArrayHasKey('created_at', $comment);
+        $this->assertArrayHasKey('updated_at', $comment);
+
+        return $comment['id'];
+    }
+    /**
+     * @test
+     * @depends shouldCreateCommentForIssue
+     */
+    public function shouldUpdateCommentByCommentId($commentId)
+    {
+        $username = 'KnpLabs';
+        $repo     = 'php-github-api';
+        $params   = array('body' => 'test update');
+
+        $comment = $this->client->api('issue')->comments()->update($username, $repo, $commentId, $params);
+
+        $this->assertArrayHasKey('id', $comment);
+        $this->assertArrayHasKey('url', $comment);
+        $this->assertArrayHasKey('body', $comment);
+        $this->assertArrayHasKey('user', $comment);
+        $this->assertArrayHasKey('created_at', $comment);
+        $this->assertArrayHasKey('updated_at', $comment);
+
+        return $comment['id'];
+    }
+
+    /**
+     * @test
+     * @depends shouldUpdateCommentByCommentId
+     */
+    public function shouldRemoveCommentByCommentId($commentId)
+    {
+        $username = 'KnpLabs';
+        $repo     = 'php-github-api';
+
+        $this->client->api('issue')->comments()->remove($username, $repo, $commentId);
+    }
+}

test/Github/Tests/Functional/UserTest.php

@@ -57,12 +57,7 @@ public function shouldGetFollowersUsers()
     {
         $username = 'KnpLabs';
 
-        $this->client = new Client();
-        try {
-            $users = $this->client->api('user')->followers($username);
-        } catch (ApiLimitExceedException $e) {
-            $this->markTestSkipped('API limit reached. Skipping to prevent unnecessary failure.');
-        }
+        $users = $this->client->api('user')->followers($username);
         $user = array_pop($users);
 
         $this->assertArrayHasKey('id', $user);