removed unit test shouldNotUpdateHookWithoutName for #442

AbstractApiTest cleanup with ReflectionMethod
createMock removed in ResultPagerTest like in #438 comment written

Author: kokspflanze

test/Github/Tests/Api/AbstractApiTest.php

@@ -29,7 +29,10 @@ public function shouldPassGETRequestToClient()
 
         $api = $this->getAbstractApiObject($client);
 
-        $this->assertEquals($expectedArray, $api->get('/path', array('param1' => 'param1value'), array('header1' => 'header1value')));
+        $method = new \ReflectionMethod($api, 'get');
+        $method->setAccessible(true);
+
+        $this->assertEquals($expectedArray, $method->invokeArgs($api, ['/path', array('param1' => 'param1value'), array('header1' => 'header1value')]));
     }
 
     /**
@@ -54,8 +57,10 @@ public function shouldPassPOSTRequestToClient()
             ->willReturn($httpClient);
 
         $api = $this->getAbstractApiObject($client);
+        $method = new \ReflectionMethod($api, 'post');
+        $method->setAccessible(true);
 
-        $this->assertEquals($expectedArray, $api->post('/path', array('param1' => 'param1value'), array('option1' => 'option1value')));
+        $this->assertEquals($expectedArray, $method->invokeArgs($api, ['/path', array('param1' => 'param1value'), array('option1' => 'option1value')]));
     }
 
     /**
@@ -80,8 +85,10 @@ public function shouldPassPATCHRequestToClient()
             ->willReturn($httpClient);
 
         $api = $this->getAbstractApiObject($client);
+        $method = new \ReflectionMethod($api, 'patch');
+        $method->setAccessible(true);
 
-        $this->assertEquals($expectedArray, $api->patch('/path', array('param1' => 'param1value'), array('option1' => 'option1value')));
+        $this->assertEquals($expectedArray, $method->invokeArgs($api, ['/path', array('param1' => 'param1value'), array('option1' => 'option1value')]));
     }
 
     /**
@@ -106,8 +113,10 @@ public function shouldPassPUTRequestToClient()
             ->willReturn($httpClient);
 
         $api = $this->getAbstractApiObject($client);
+        $method = new \ReflectionMethod($api, 'put');
+        $method->setAccessible(true);
 
-        $this->assertEquals($expectedArray, $api->put('/path', array('param1' => 'param1value'), array('option1' => 'option1value')));
+        $this->assertEquals($expectedArray, $method->invokeArgs($api, ['/path', array('param1' => 'param1value'), array('option1' => 'option1value')]));
     }
 
     /**
@@ -133,8 +142,10 @@ public function shouldPassDELETERequestToClient()
 
 
         $api = $this->getAbstractApiObject($client);
+        $method = new \ReflectionMethod($api, 'delete');
+        $method->setAccessible(true);
 
-        $this->assertEquals($expectedArray, $api->delete('/path', array('param1' => 'param1value'), array('option1' => 'option1value')));
+        $this->assertEquals($expectedArray, $method->invokeArgs($api, ['/path', array('param1' => 'param1value'), array('option1' => 'option1value')]));
     }
 
     /**
@@ -159,12 +170,22 @@ public function shouldNotPassEmptyRefToClient()
             ->willReturn($httpClient);
 
         $api = $this->getAbstractApiObject($client);
-        $api->get('/path', array('ref' => null));
+        $method = new \ReflectionMethod($api, 'get');
+        $method->setAccessible(true);
+
+        $this->assertInternalType('array', $method->invokeArgs($api, ['/path', array('ref' => null)]));
     }
 
+    /**
+     * @param $client
+     * @return AbstractApi
+     */
     protected function getAbstractApiObject($client)
     {
-        return new AbstractApiTestInstance($client);
+        return $this->getMockBuilder(AbstractApi::class)
+            ->setMethods(null)
+            ->setConstructorArgs([$client])
+            ->getMock();
     }
 
     /**
@@ -223,68 +244,3 @@ private function getPSR7Response($expectedArray)
         );
     }
 }
-
-class AbstractApiTestInstance extends AbstractApi
-{
-    /**
-     * {@inheritDoc}
-     */
-    public function get($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::get($path, $parameters, $requestHeaders);
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function post($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::post($path, $parameters, $requestHeaders);
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function postRaw($path, $body, $requestHeaders = array())
-    {
-        return parent::postRaw($path, $body, $requestHeaders);
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function patch($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::patch($path, $parameters, $requestHeaders);
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function put($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::put($path, $parameters, $requestHeaders);
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function delete($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::delete($path, $parameters, $requestHeaders);
-    }
-}
-
-/**
- * @deprecated
- */
-class ExposedAbstractApiTestInstance extends AbstractApi
-{
-    /**
-     * {@inheritDoc}
-     */
-    public function get($path, array $parameters = array(), $requestHeaders = array())
-    {
-        return parent::get($path, $parameters, $requestHeaders);
-    }
-}

test/Github/Tests/Api/Repository/HooksTest.php

@@ -101,21 +101,6 @@ public function shouldCreateHook()
         $this->assertEquals($expectedValue, $api->create('KnpLabs', 'php-github-api', $data));
     }
 
-    /**
-     * @test
-     * @expectedException \Github\Exception\MissingArgumentException
-     */
-    public function shouldNotUpdateHookWithoutName()
-    {
-        $data = array('config' => 'someconf');
-
-        $api = $this->getApiMock();
-        $api->expects($this->never())
-            ->method('patch');
-
-        $api->update('KnpLabs', 'php-github-api', 123, $data);
-    }
-
     /**
      * @test
      * @expectedException \Github\Exception\MissingArgumentException

test/Github/Tests/Api/TestCase.php

@@ -6,9 +6,12 @@ abstract class TestCase extends \PHPUnit_Framework_TestCase
 {
     abstract protected function getApiClass();
 
+    /**
+     * @return \PHPUnit_Framework_MockObject_MockObject
+     */
     protected function getApiMock()
     {
-        $httpClient = $this->getMockBuilder('Http\Client\HttpClient')
+        $httpClient = $this->getMockBuilder(\Http\Client\HttpClient::class)
             ->setMethods(array('sendRequest'))
             ->getMock();
         $httpClient

test/Github/Tests/ResultPagerTest.php

@@ -101,7 +101,8 @@ public function testFetch()
         $result = 'foo';
         $method = 'bar';
         $parameters = array('baz');
-        $api = $this->createMock('Github\Api\ApiInterface');
+        $api = $this->getMockBuilder('Github\Api\ApiInterface')
+            ->getMock();
 
         $paginator = $this->getMockBuilder('Github\ResultPager')
             ->disableOriginalConstructor()