Update ResponseMediator to use type conversion, closes #263

cursedcoder · cursedcoder · commit 8727a7fecf4a · 2015-05-26T11:06:44.000+08:00
diff --git a/lib/Github/HttpClient/Message/ResponseMediator.php b/lib/Github/HttpClient/Message/ResponseMediator.php
@@ -21,7 +21,7 @@ public static function getContent(Response $response)
 
     public static function getPagination(Response $response)
     {
-        $header = $response->getHeader('Link');
+        $header = (string) $response->getHeader('Link');
 
         if (empty($header)) {
             return null;
@@ -41,7 +41,7 @@ public static function getPagination(Response $response)
 
     public static function getApiLimit(Response $response)
     {
-        $remainingCalls = $response->getHeader('X-RateLimit-Remaining');
+        $remainingCalls = (string) $response->getHeader('X-RateLimit-Remaining');
 
         if (null !== $remainingCalls && 1 > $remainingCalls) {
             throw new ApiLimitExceedException($remainingCalls);

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public static function getContent(Response $response)`
`21`	`21`
`22`	`22`	`public static function getPagination(Response $response)`
`23`	`23`	`{`
`24`		`- $header = $response->getHeader('Link');`
	`24`	`+ $header = (string) $response->getHeader('Link');`
`25`	`25`
`26`	`26`	`if (empty($header)) {`
`27`	`27`	`return null;`
`@@ -41,7 +41,7 @@ public static function getPagination(Response $response)`
`41`	`41`
`42`	`42`	`public static function getApiLimit(Response $response)`
`43`	`43`	`{`
`44`		`- $remainingCalls = $response->getHeader('X-RateLimit-Remaining');`
	`44`	`+ $remainingCalls = (string) $response->getHeader('X-RateLimit-Remaining');`
`45`	`45`
`46`	`46`	`if (null !== $remainingCalls && 1 > $remainingCalls) {`
`47`	`47`	`throw new ApiLimitExceedException($remainingCalls);`