Merge pull request #87 from kasperg/patch-1

cursedcoder · cursedcoder · commit 92203a6e024b · 2013-11-15T09:15:59.000-08:00
Do not report validation errors as rate limits
diff --git a/lib/Github/HttpClient/Listener/ErrorListener.php b/lib/Github/HttpClient/Listener/ErrorListener.php
@@ -41,7 +41,7 @@ public function onRequestError(Event $event)
         if ($response->isClientError() || $response->isServerError()) {
             $remaining = (string) $response->getHeader('X-RateLimit-Remaining');
 
-            if (null !== $remaining && 1 > $remaining && 'rate_limit' !== substr($request->getResource(), 1, 10)) {
+            if (null != $remaining && 1 > $remaining && 'rate_limit' !== substr($request->getResource(), 1, 10)) {
                 throw new ApiLimitExceedException($this->options['api_limit']);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function onRequestError(Event $event)`
`41`	`41`	`if ($response->isClientError() \|\| $response->isServerError()) {`
`42`	`42`	`$remaining = (string) $response->getHeader('X-RateLimit-Remaining');`
`43`	`43`
`44`		`- if (null !== $remaining && 1 > $remaining && 'rate_limit' !== substr($request->getResource(), 1, 10)) {`
	`44`	`+ if (null != $remaining && 1 > $remaining && 'rate_limit' !== substr($request->getResource(), 1, 10)) {`
`45`	`45`	`throw new ApiLimitExceedException($this->options['api_limit']);`
`46`	`46`	`}`
`47`	`47`