Fix for edge case when no params used in GET call

stloyd · stloyd · commit be1086c6097b · 2012-08-28T16:17:56.000+03:00
diff --git a/lib/Github/HttpClient/HttpClient.php b/lib/Github/HttpClient/HttpClient.php
@@ -127,7 +127,9 @@ public function getPagination()
      */
     public function get($path, array $parameters = array(), array $options = array())
     {
-        $path .= (false === strpos($path, '?') ? '?' : '&').http_build_query($parameters, '', '&');
+        if (0 < count($parameters)) {
+            $path .= (false === strpos($path, '?') ? '?' : '&').http_build_query($parameters, '', '&');
+        }
 
         return $this->request($path, array(), 'GET', $options);
     }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,9 @@ public function getPagination()`
`127`	`127`	`*/`
`128`	`128`	`public function get($path, array $parameters = array(), array $options = array())`
`129`	`129`	`{`
`130`		`- $path .= (false === strpos($path, '?') ? '?' : '&').http_build_query($parameters, '', '&');`
	`130`	`+ if (0 < count($parameters)) {`
	`131`	`+ $path .= (false === strpos($path, '?') ? '?' : '&').http_build_query($parameters, '', '&');`
	`132`	`+ }`
`131`	`133`
`132`	`134`	`return $this->request($path, array(), 'GET', $options);`
`133`	`135`	`}`