refactor: update and fix some issues for symfony 7

Author: AntoineGonzalez

composer.json

@@ -56,7 +56,8 @@
     },
     "config": {
         "allow-plugins": {
-            "symfony/*": true
+            "symfony/*": true,
+            "php-http/discovery": true
         },
         "optimize-autoloader": true,
         "preferred-install": {

config/services.yaml

@@ -14,3 +14,6 @@ services:
         resource: '../src/Application/'
         exclude:
           - '../src/Application/DomainEventsHandler/'
+
+    Infrastructure\Doctrine\DataFixtures\:
+        resource: '../src/Infrastructure/Doctrine/DataFixtures/**.php'

config/services/doctrine_event_listeners.yaml

@@ -8,4 +8,4 @@ services:
   Infrastructure\Doctrine\EventListener\HashUserPasswordListener:
     tags:
       - { name: doctrine.event_listener, event: prePersist }
-      - { name: doctrine.event_listener, event: preUpdate }
+      - { name: doctrine.event_listener, event: preUpdate }

config/services/domain_events.yaml

@@ -2,6 +2,7 @@
 services:
   _defaults:
     autowire: true
+    autoconfigure: true
     public: false
 
   Domain\EventsRegisterer: ~

config/services/use_cases.yaml

@@ -8,4 +8,4 @@ services:
   Domain\UseCase\:
     resource: '%kernel.project_dir%/src/Domain/UseCase/**/Handler.php'
     tags:
-      - { name: messenger.message_handler, bus: command.bus }
+      - { name: messenger.message_handler, bus: command.bus }

src/Application/Controller/AuthenticationController.php

@@ -18,8 +18,8 @@
 final class AuthenticationController extends AbstractController
 {
     public function __construct(
-        private UsersCollection $usersCollection,
-        private CommandBus $commandBus
+        private readonly UsersCollection $usersCollection,
+        private readonly CommandBus $commandBus
     ) {
     }
 

src/Application/Controller/DinosaursController.php

@@ -7,7 +7,6 @@
 use Application\MessageBus\CommandBus;
 use Application\MessageBus\EventBus;
 use Application\MessageBus\QueryBus;
-use Domain\Event\DinosaurIsBorn;
 use Domain\Exception\DinosaurNotFoundException;
 use Domain\Query\GetSingleDinosaur;
 use Domain\Query\GetAllDinosaurs;
@@ -23,9 +22,9 @@
 final class DinosaursController extends AbstractController
 {
     public function __construct(
-        private CommandBus $commandBus,
-        private QueryBus $queryBus,
-        private EventBus $eventBus
+        private readonly CommandBus $commandBus,
+        private readonly QueryBus $queryBus,
+        private readonly EventBus $eventBus
     ) {
     }
 

src/Application/Controller/SpeciesController.php

@@ -22,8 +22,8 @@
 final class SpeciesController extends AbstractController
 {
     public function __construct(
-        private CommandBus $commandBus,
-        private QueryBus $queryBus
+        private readonly CommandBus $commandBus,
+        private readonly QueryBus $queryBus
     ) {
     }
 

src/Application/DomainEventsHandler/LogWhenDinosaurDied.php

@@ -5,31 +5,22 @@
 namespace Application\DomainEventsHandler;
 
 use Domain\Event\DinosaurDied;
-use Domain\Event\EventInterface;
 use Psr\Log\LoggerInterface;
-use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class LogWhenDinosaurDied implements MessageSubscriberInterface
+#[AsMessageHandler]
+final class LogWhenDinosaurDied
 {
     public function __construct(
-        private LoggerInterface $logger
+        private readonly LoggerInterface $logger,
     ) {
     }
 
-    public function __invoke(EventInterface $event): void
+    public function __invoke(DinosaurDied $event): void
     {
-        if (!$event instanceof DinosaurDied) {
-            return;
-        }
-
-        $this->logger->info(sprintf(
+        $this->logger->info(\sprintf(
             'Dinosaur %s died',
-            $event->getDinosaurName()
+            $event->dinosaurName
         ));
     }
-
-    public static function getHandledMessages(): iterable
-    {
-        yield DinosaurDied::class;
-    }
 }

src/Application/DomainEventsHandler/LogWhenDinosaurIsBorn.php

@@ -6,38 +6,27 @@
 
 use Domain\Collection\DinosaursCollection;
 use Domain\Event\DinosaurIsBorn;
-use Domain\Event\EventInterface;
-use Domain\Exception\DinosaurNotFoundException;
-use Domain\Model\Dinosaur;
 use Psr\Log\LoggerInterface;
-use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class LogWhenDinosaurIsBorn implements MessageSubscriberInterface
+#[AsMessageHandler]
+final class LogWhenDinosaurIsBorn
 {
     public function __construct(
-        private DinosaursCollection $dinosaursCollection,
-        private LoggerInterface $logger
+        private readonly DinosaursCollection $dinosaursCollection,
+        private readonly LoggerInterface $logger
     ) {
     }
 
-    public function __invoke(EventInterface $event): void
+    public function __invoke(DinosaurIsBorn $event): void
     {
         $dinosaurId = $event->getAggregateRootId();
 
         $dinosaur = $this->dinosaursCollection->find($dinosaurId);
 
-        if (!$dinosaur instanceof Dinosaur) {
-            throw new DinosaurNotFoundException($dinosaurId);
-        }
-
-        $this->logger->info(sprintf(
+        $this->logger->info(\sprintf(
             'Dinosaur %s was born',
             $dinosaur->getName()
         ));
     }
-
-    public static function getHandledMessages(): iterable
-    {
-        yield DinosaurIsBorn::class;
-    }
 }