Skip to content

Commit 6e5ea2d

Browse files
committed
fix: cached add/remove roles
1 parent a465641 commit 6e5ea2d

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

api/src/guilds/tasks.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use lambda_http::tracing::info;
44
use regex::Regex;
55
use twilight_model::id::Id;
66
use twilight_model::id::marker::{GuildMarker, RoleMarker, UserMarker};
7-
use crate::discord::{add_guild_member_role, get_guild_member, remove_guild_member_role};
7+
use crate::discord::{add_guild_member_role, get_guild_member, get_guild_member_no_cache, remove_guild_member_role};
88
use crate::guilds::verify::models::VerifyRole;
99

1010
async fn assign_role_user(
@@ -72,7 +72,7 @@ pub async fn assign_roles_guild_user_link(
7272
let roles = &mut guild.verify.roles;
7373
for i in 0..roles.len() {
7474
let role = roles.get_mut(i).unwrap();
75-
let has_dsc_role = get_guild_member(guild.guild_id, user_id, bot).await?.roles.contains(&role.role_id);
75+
let has_dsc_role = get_guild_member_no_cache(guild.guild_id, user_id, bot).await?.roles.contains(&role.role_id);
7676
if enabled && Regex::new(&role.pattern)
7777
.unwrap()
7878
.is_match(link_address)
@@ -86,7 +86,9 @@ pub async fn assign_roles_guild_user_link(
8686
info!("Removing role {} from user {}", role.role_id, user_id);
8787
if has_dsc_role {
8888
remove_role_user(guild.guild_id, user_id, role.role_id, bot).await?;
89-
role.members -= 1;
89+
if role.members != 0 {
90+
role.members -= 1;
91+
}
9092
}
9193
}
9294
}

ui/src/components/dashboard/VerifyComponent.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ function validAdd() {
124124
<fa :icon="['fas', 'ellipsis']"/>
125125
</div>
126126
<ul tabindex="0" class="dropdown-content menu bg-base-100 rounded-box z-1 p-2 shadow-sm">
127-
<li><a>Edit</a></li>
127+
<!-- <li><a>Edit</a></li>-->
128128
<li class="text-error" @click="removeVerifyRole(role)"><a>Remove</a></li>
129129
</ul>
130130
</div>

ui/src/components/discord/DiscordTag.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ let props = defineProps({
1111
</script>
1212

1313
<template>
14-
<div class="badge badge-neutral badge-outline bg-base-100" :style="{'border-color': '#AAAAAA', '--badge-bg': 'var(--color-base)'}">
14+
<div class="badge badge-neutral badge-outline bg-base-100 text-base-content" :style="{'border-color': '#AAAAAA', '--badge-bg': 'var(--color-base)'}">
1515
<div class="indicator">
1616
<slot></slot>
1717
<div class="place-items-center">{{ label }}</div>

0 commit comments

Comments
 (0)