Minor improvements

Author: Kocal

composer.json

@@ -10,6 +10,11 @@
         }
     ],
     "scripts": {
+        "qa-fix": [
+            "@cs-fix",
+            "@phpstan",
+            "@test"
+        ],
         "phpstan": "vendor/bin/phpstan analyze",
         "test": "vendor/bin/phpunit",
         "cs": "vendor/bin/ecs check",
@@ -30,7 +35,7 @@
         "phpstan/phpstan": "^2.1.13"
     },
     "require-dev": {
-        "phpunit/phpunit": "^11.0",
+        "phpunit/phpunit": "^11.1",
         "symfony/ux-twig-component": "^2.0",
         "symplify/easy-coding-standard": "^13.0"
     },

src/NodeAnalyzer/AttributeFinder.php

@@ -8,8 +8,8 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassLike;
+use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
-use PHPStan\Node\ClassMethod;
 
 /**
  * Heavily inspired by https://github.com/symplify/phpstan-rules/blob/main/src/NodeAnalyzer/AttributeFinder.php <3

src/Rules/TwigComponent/ForbiddenAttributesPropertyRule.php

@@ -8,6 +8,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;
@@ -17,6 +18,11 @@
  */
 final class ForbiddenAttributesPropertyRule implements Rule
 {
+    public function __construct(
+        private ReflectionProvider $reflectionProvider,
+    ) {
+    }
+
     public function getNodeType(): string
     {
         return Class_::class;
@@ -51,7 +57,7 @@ public function processNode(Node $node, Scope $scope): array
     }
 
     /**
-     * @return {name: string, custom: false}|null
+     * @return array{name: string, custom: bool}|null
      */
     private function getAttributesVarName(Node\Attribute $attribute): ?array
     {
@@ -66,11 +72,11 @@ private function getAttributesVarName(Node\Attribute $attribute): ?array
             }
         }
 
-        $reflAttribute = new \ReflectionClass(AsTwigComponent::class);
-        foreach ($reflAttribute->getConstructor()->getParameters() as $reflParameter) {
-            if ($reflParameter->getName() === 'attributesVar' && $reflParameter->isDefaultValueAvailable()) {
+        $reflAttribute = $this->reflectionProvider->getClass(AsTwigComponent::class);
+        foreach ($reflAttribute->getConstructor()->getOnlyVariant()->getParameters() as $reflParameter) {
+            if ($reflParameter->getName() === 'attributesVar' && $reflParameter->getDefaultValue()?->getConstantStrings()) {
                 return [
-                    'name' => $reflParameter->getDefaultValue(),
+                    'name' => $reflParameter->getDefaultValue()->getConstantStrings()[0]->getValue(),
                     'custom' => false,
                 ];
             }

tests/Rules/TwigComponent/ForbiddenAttributesPropertyRule/Fixture/ComponentWithAttributesProperty.php

@@ -9,5 +9,5 @@
 #[AsTwigComponent]
 final class ComponentWithAttributesProperty
 {
-    public $attributes;
+    public string $attributes;
 }

tests/Rules/TwigComponent/ForbiddenAttributesPropertyRule/Fixture/ComponentWithCustomAttributesProperty.php

@@ -9,5 +9,5 @@
 #[AsTwigComponent(attributesVar: 'customAttributes')]
 final class ComponentWithAttributesProperty
 {
-    public $customAttributes;
+    public string $customAttributes;
 }

tests/Rules/TwigComponent/ForbiddenAttributesPropertyRule/Fixture/NotAComponent.php

@@ -6,5 +6,8 @@
 
 final class NotAComponent
 {
-    public $attributes;
+    /**
+     * @var array<string, mixed>
+     */
+    public array $attributes;
 }

tests/Rules/TwigComponent/ForbiddenAttributesPropertyRule/ForbiddenAttributesPropertyRuleTest.php

@@ -8,6 +8,9 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
+/**
+ * @extends RuleTestCase<ForbiddenAttributesPropertyRule>
+ */
 final class ForbiddenAttributesPropertyRuleTest extends RuleTestCase
 {
     public function testViolations(): void
@@ -41,14 +44,20 @@ public function testNoViolations(): void
             [__DIR__ . '/Fixture/NotAComponent.php'],
             []
         );
+
         $this->analyse(
             [__DIR__ . '/Fixture/ComponentWithNoAttributesProperty.php'],
             []
         );
     }
 
+    public static function getAdditionalConfigFiles(): array
+    {
+        return [__DIR__ . '/config/configured_rule.neon'];
+    }
+
     protected function getRule(): Rule
     {
-        return new ForbiddenAttributesPropertyRule();
+        return self::getContainer()->getByType(ForbiddenAttributesPropertyRule::class);
     }
 }

tests/Rules/TwigComponent/ForbiddenAttributesPropertyRule/config/configured_rule.neon

@@ -0,0 +1,2 @@
+rules:
+    - Kocal\PHPStanSymfonyUX\Rules\TwigComponent\ForbiddenAttributesPropertyRule

tests/Rules/TwigComponent/ForbiddenClassPropertyRule/Fixture/ComponentWithClassProperty.php

@@ -9,5 +9,5 @@
 #[AsTwigComponent]
 final class ComponentWithClassProperty
 {
-    public $class;
+    public string $class;
 }

tests/Rules/TwigComponent/ForbiddenClassPropertyRule/Fixture/NotAComponent.php

@@ -6,5 +6,5 @@
 
 final class NotAComponent
 {
-    public $attributes;
+    public string $class;
 }