iterate

Author: Kocal

.github/workflows/browser-tests.yml

@@ -35,5 +35,9 @@ jobs:
                         package.json
                         src/**/package.json
             -   run: pnpm install --frozen-lockfile
+
+            -   name: Install browsers
+                run: node ./bin/get_browsers.js
+
             # TODO: Install the E2E app + run webserver
             -   run: pnpm run test:browser

bin/get_browsers.mjs

@@ -0,0 +1,45 @@
+import * as path from 'node:path';
+import {
+    Browser,
+    BrowserTag,
+    detectBrowserPlatform,
+    install as installBrowser,
+    resolveBuildId,
+} from '@puppeteer/browsers';
+
+const platform = detectBrowserPlatform();
+const installBrowserCommonOpts = {
+    platform,
+    cacheDir: path.join(import.meta.dirname, '../browsers'),
+};
+
+// Lowest versions are computed from "defaults and fully supports es6-module" query,
+// see https://browsersl.ist/#q=defaults+and+fully+supports+es6-module
+
+export const browsers = {
+    'chrome@lowest': await installBrowser({
+        ...installBrowserCommonOpts,
+        browser: Browser.CHROME,
+        // The lowest version where:
+        // - Chrome and associated Chromedriver could easily be downloaded
+        // - there is no compatibility issues like "WebDriver Bidi command \"session.subscribe\" failed with error"
+        // - there is no timeout issues when requesting Vitest webserver
+        // @see https://raw.githubusercontent.com/GoogleChromeLabs/chrome-for-testing/refs/heads/main/data/known-good-versions-with-downloads.json
+        buildId: '130.0.6669.0',
+    }),
+    'chrome@latest': await installBrowser({
+        ...installBrowserCommonOpts,
+        browser: Browser.CHROME,
+        buildId: await resolveBuildId(Browser.CHROME, platform, BrowserTag.STABLE),
+    }),
+    'firefox@lowest': await installBrowser({
+        ...installBrowserCommonOpts,
+        browser: Browser.FIREFOX,
+        buildId: 'stable_128.0',
+    }),
+    'firefox@latest': await installBrowser({
+        ...installBrowserCommonOpts,
+        browser: Browser.FIREFOX,
+        buildId: await resolveBuildId(Browser.FIREFOX, platform, BrowserTag.STABLE),
+    }),
+};

biome.json

@@ -12,7 +12,8 @@
             "!**/package.json",
             "!**/node_modules",
             "!**/var",
-            "!**/dist"
+            "!**/dist",
+            "!**/browsers"
         ]
     },
     "linter": {

src/StimulusBundle/assets/package.json

@@ -19,7 +19,6 @@
         "watch": "tsx ../../../bin/build_package.ts . --watch",
         "test": "pnpm run test:unit",
         "test:unit": "../../../bin/test_package.sh . --unit",
-        "test:browser": "../../../bin/test_package.sh . --browser",
         "check": "biome check",
         "ci": "biome ci"
     },

vitest.config.mjs

@@ -1,49 +1,7 @@
 /// <reference types="@vitest/browser/providers/webdriverio" />
 import { defineConfig } from 'vitest/config';
 import path from 'node:path';
-import {
-    Browser,
-    BrowserTag,
-    detectBrowserPlatform,
-    install as installBrowser,
-    resolveBuildId,
-} from '@puppeteer/browsers';
-
-const platform = detectBrowserPlatform();
-const installBrowserCommonOpts = {
-    platform,
-    cacheDir: path.join(__dirname, 'browsers'),
-}
-
-// Lowest versions are computed from "defaults and fully supports es6-module" query,
-// see https://browsersl.ist/#q=defaults+and+fully+supports+es6-module
-const browsers = {
-    'chrome@lowest': await installBrowser({
-        ...installBrowserCommonOpts,
-        browser: Browser.CHROME,
-        // The lowest version where:
-        // - Chrome and associated Chromedriver could easily be downloaded
-        // - there is no compatibility issues like "WebDriver Bidi command \"session.subscribe\" failed with error"
-        // - there is no timeout issues when requesting Vitest webserver
-        // @see https://raw.githubusercontent.com/GoogleChromeLabs/chrome-for-testing/refs/heads/main/data/known-good-versions-with-downloads.json
-        buildId: '130.0.6669.0',
-    }),
-    'chrome@latest': await installBrowser({
-        ...installBrowserCommonOpts,
-        browser: Browser.CHROME,
-        buildId: await resolveBuildId(Browser.CHROME, platform, BrowserTag.STABLE),
-    }),
-    'firefox@lowest': await installBrowser({
-        ...installBrowserCommonOpts,
-        browser: Browser.FIREFOX,
-        buildId: 'stable_128.0',
-    }),
-    'firefox@latest': await installBrowser({
-        ...installBrowserCommonOpts,
-        browser: Browser.FIREFOX,
-        buildId: await resolveBuildId(Browser.FIREFOX, platform, BrowserTag.STABLE),
-    }),
-};
+import { browsers } from './bin/get_browsers.mjs';
 
 console.log('Using the following browsers:', browsers);