Commit 261ad58
committed
minor symfony#2465 [Site] Visual improvments on IconModal (Kocal)
This PR was squashed before being merged into the 2.x branch.
Discussion
----------
[Site] Visual improvments on IconModal
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- For new features, provide some code snippets to help understand usage.
- Features and deprecations must be submitted against branch main.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
- Never break backward compatibility (see https://symfony.com/bc).
-->
The `lightsky` color was hard to read on a grey background, I changed it to the Bootstrap code color and it is better (it still does not pass accessibility tests, but that's better). I also changed the active `Tab` background-color:
<img width="1800" alt="Capture d’écran 2024-12-23 à 09 18 52" src="https://github.com/user-attachments/assets/abffd1b2-17be-419b-a6ae-7281d82b65fe" />
On mobile, or resized window, opening and use the `IconModal` was not convenient, so I adapted it:
<img width="1800" alt="Capture d’écran 2024-12-23 à 09 17 41" src="https://github.com/user-attachments/assets/d84d4af2-66e4-404d-b032-46a41bca2a76" />
Commits
-------
610db72 [Site] Improve IconModal display on mobile
21d9557 [Site] Improve contrast on IconModalFile tree
2 files changed
+21
-5
lines changed- ux.symfony.com/assets/styles/components
2 files changed
+21
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
| |||
176 | 175 | | |
177 | 176 | | |
178 | 177 | | |
179 | | - | |
| 178 | + | |
180 | 179 | | |
181 | 180 | | |
182 | 181 | | |
| |||
212 | 211 | | |
213 | 212 | | |
214 | 213 | | |
215 | | - | |
| 214 | + | |
216 | 215 | | |
217 | 216 | | |
218 | 217 | | |
| |||
239 | 238 | | |
240 | 239 | | |
241 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
0 commit comments