Skip to content

Commit 49449f2

Browse files
KocalKocal
committed
minor symfony#2429 [Meta] Replace CleanCSS by LightningCSS (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [Meta] Replace CleanCSS by LightningCSS | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> One more step to modernize our build stack, by replacing https://github.com/clean-css/clean-css by https://lightningcss.dev/. TBH it does not bring a lot of value since we only have 4 very small CSS files, buuuut that's for a better future :) ([#rolldown](rolldown/rolldown#153 (comment))) Commits ------- 3f2e4f4 [Meta] Replace CleanCSS by Lightning CSS
2 parents bcae0c4 + 3f2e4f4 commit 49449f2

File tree

6 files changed

+132
-17
lines changed

6 files changed

+132
-17
lines changed

‎bin/build_package.js‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const path = require('node:path');
77
const fs = require('node:fs');
88
const glob = require('glob');
99
const rollup = require('rollup');
10-
const CleanCSS = require('clean-css');
10+
const LightningCSS = require('lightningcss');
1111
const { getRollupConfiguration } = require('./rollup');
1212

1313
const args = parseArgs({
@@ -70,7 +70,12 @@ async function main() {
7070

7171
console.log('Minifying CSS...');
7272
const css = await fs.promises.readFile(inputStyleFile, 'utf-8');
73-
const minified = new CleanCSS().minify(css).styles;
73+
const { code: minified } = LightningCSS.transform({
74+
filename: path.basename(inputStyleFile, '.css'),
75+
code: Buffer.from(css),
76+
minify: true,
77+
sourceMap: false, // TODO: Maybe we can add source maps later? :)
78+
});
7479
await fs.promises.writeFile(inputStyleFileDist, minified);
7580
};
7681

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"@rollup/plugin-typescript": "^11.1.6",
2323
"@symfony/stimulus-testing": "^2.0.1",
2424
"@vitest/browser": "^2.1.1",
25-
"clean-css": "^5.3.3",
25+
"lightningcss": "^1.28.2",
2626
"playwright": "^1.47.0",
2727
"rollup": "^4.22.5",
2828
"tslib": "^2.6.3",

‎src/Dropzone/assets/dist/style.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/LiveComponent/assets/dist/live.min.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
[data-loading=""],[data-loading="delay|show"],[data-loading=show]{display:none}
1+
[data-loading=""],[data-loading=show],[data-loading=delay\|show]{display:none}

‎src/TogglePassword/assets/dist/style.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎yarn.lock‎

Lines changed: 121 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4423,15 +4423,6 @@ __metadata:
44234423
languageName: node
44244424
linkType: hard
44254425

4426-
"clean-css@npm:^5.3.3":
4427-
version: 5.3.3
4428-
resolution: "clean-css@npm:5.3.3"
4429-
dependencies:
4430-
source-map: "npm:~0.6.0"
4431-
checksum: 10c0/381de7523e23f3762eb180e327dcc0cedafaf8cb1cd8c26b7cc1fc56e0829a92e734729c4f955394d65ed72fb62f82d8baf78af34b33b8a7d41ebad2accdd6fb
4432-
languageName: node
4433-
linkType: hard
4434-
44354426
"clean-stack@npm:^2.0.0":
44364427
version: 2.2.0
44374428
resolution: "clean-stack@npm:2.2.0"
@@ -4903,6 +4894,15 @@ __metadata:
49034894
languageName: node
49044895
linkType: hard
49054896

4897+
"detect-libc@npm:^1.0.3":
4898+
version: 1.0.3
4899+
resolution: "detect-libc@npm:1.0.3"
4900+
bin:
4901+
detect-libc: ./bin/detect-libc.js
4902+
checksum: 10c0/4da0deae9f69e13bc37a0902d78bf7169480004b1fed3c19722d56cff578d16f0e11633b7fbf5fb6249181236c72e90024cbd68f0b9558ae06e281f47326d50d
4903+
languageName: node
4904+
linkType: hard
4905+
49064906
"detect-newline@npm:^3.0.0":
49074907
version: 3.1.0
49084908
resolution: "detect-newline@npm:3.1.0"
@@ -7132,6 +7132,116 @@ __metadata:
71327132
languageName: node
71337133
linkType: hard
71347134

7135+
"lightningcss-darwin-arm64@npm:1.28.2":
7136+
version: 1.28.2
7137+
resolution: "lightningcss-darwin-arm64@npm:1.28.2"
7138+
conditions: os=darwin & cpu=arm64
7139+
languageName: node
7140+
linkType: hard
7141+
7142+
"lightningcss-darwin-x64@npm:1.28.2":
7143+
version: 1.28.2
7144+
resolution: "lightningcss-darwin-x64@npm:1.28.2"
7145+
conditions: os=darwin & cpu=x64
7146+
languageName: node
7147+
linkType: hard
7148+
7149+
"lightningcss-freebsd-x64@npm:1.28.2":
7150+
version: 1.28.2
7151+
resolution: "lightningcss-freebsd-x64@npm:1.28.2"
7152+
conditions: os=freebsd & cpu=x64
7153+
languageName: node
7154+
linkType: hard
7155+
7156+
"lightningcss-linux-arm-gnueabihf@npm:1.28.2":
7157+
version: 1.28.2
7158+
resolution: "lightningcss-linux-arm-gnueabihf@npm:1.28.2"
7159+
conditions: os=linux & cpu=arm
7160+
languageName: node
7161+
linkType: hard
7162+
7163+
"lightningcss-linux-arm64-gnu@npm:1.28.2":
7164+
version: 1.28.2
7165+
resolution: "lightningcss-linux-arm64-gnu@npm:1.28.2"
7166+
conditions: os=linux & cpu=arm64 & libc=glibc
7167+
languageName: node
7168+
linkType: hard
7169+
7170+
"lightningcss-linux-arm64-musl@npm:1.28.2":
7171+
version: 1.28.2
7172+
resolution: "lightningcss-linux-arm64-musl@npm:1.28.2"
7173+
conditions: os=linux & cpu=arm64 & libc=musl
7174+
languageName: node
7175+
linkType: hard
7176+
7177+
"lightningcss-linux-x64-gnu@npm:1.28.2":
7178+
version: 1.28.2
7179+
resolution: "lightningcss-linux-x64-gnu@npm:1.28.2"
7180+
conditions: os=linux & cpu=x64 & libc=glibc
7181+
languageName: node
7182+
linkType: hard
7183+
7184+
"lightningcss-linux-x64-musl@npm:1.28.2":
7185+
version: 1.28.2
7186+
resolution: "lightningcss-linux-x64-musl@npm:1.28.2"
7187+
conditions: os=linux & cpu=x64 & libc=musl
7188+
languageName: node
7189+
linkType: hard
7190+
7191+
"lightningcss-win32-arm64-msvc@npm:1.28.2":
7192+
version: 1.28.2
7193+
resolution: "lightningcss-win32-arm64-msvc@npm:1.28.2"
7194+
conditions: os=win32 & cpu=arm64
7195+
languageName: node
7196+
linkType: hard
7197+
7198+
"lightningcss-win32-x64-msvc@npm:1.28.2":
7199+
version: 1.28.2
7200+
resolution: "lightningcss-win32-x64-msvc@npm:1.28.2"
7201+
conditions: os=win32 & cpu=x64
7202+
languageName: node
7203+
linkType: hard
7204+
7205+
"lightningcss@npm:^1.28.2":
7206+
version: 1.28.2
7207+
resolution: "lightningcss@npm:1.28.2"
7208+
dependencies:
7209+
detect-libc: "npm:^1.0.3"
7210+
lightningcss-darwin-arm64: "npm:1.28.2"
7211+
lightningcss-darwin-x64: "npm:1.28.2"
7212+
lightningcss-freebsd-x64: "npm:1.28.2"
7213+
lightningcss-linux-arm-gnueabihf: "npm:1.28.2"
7214+
lightningcss-linux-arm64-gnu: "npm:1.28.2"
7215+
lightningcss-linux-arm64-musl: "npm:1.28.2"
7216+
lightningcss-linux-x64-gnu: "npm:1.28.2"
7217+
lightningcss-linux-x64-musl: "npm:1.28.2"
7218+
lightningcss-win32-arm64-msvc: "npm:1.28.2"
7219+
lightningcss-win32-x64-msvc: "npm:1.28.2"
7220+
dependenciesMeta:
7221+
lightningcss-darwin-arm64:
7222+
optional: true
7223+
lightningcss-darwin-x64:
7224+
optional: true
7225+
lightningcss-freebsd-x64:
7226+
optional: true
7227+
lightningcss-linux-arm-gnueabihf:
7228+
optional: true
7229+
lightningcss-linux-arm64-gnu:
7230+
optional: true
7231+
lightningcss-linux-arm64-musl:
7232+
optional: true
7233+
lightningcss-linux-x64-gnu:
7234+
optional: true
7235+
lightningcss-linux-x64-musl:
7236+
optional: true
7237+
lightningcss-win32-arm64-msvc:
7238+
optional: true
7239+
lightningcss-win32-x64-msvc:
7240+
optional: true
7241+
checksum: 10c0/3318770bc7cce1d18acd219ea1e988456b6a5f90a4c09cf12c9ef39c5d4fafff9ba18e798f828131c6d9ece9ae8d544de670becb226ed16e243353c88abc9b41
7242+
languageName: node
7243+
linkType: hard
7244+
71357245
"lines-and-columns@npm:^1.1.6":
71367246
version: 1.2.4
71377247
resolution: "lines-and-columns@npm:1.2.4"
@@ -8683,7 +8793,7 @@ __metadata:
86838793
"@rollup/plugin-typescript": "npm:^11.1.6"
86848794
"@symfony/stimulus-testing": "npm:^2.0.1"
86858795
"@vitest/browser": "npm:^2.1.1"
8686-
clean-css: "npm:^5.3.3"
8796+
lightningcss: "npm:^1.28.2"
86878797
playwright: "npm:^1.47.0"
86888798
rollup: "npm:^4.22.5"
86898799
tslib: "npm:^2.6.3"
@@ -9028,7 +9138,7 @@ __metadata:
90289138
languageName: node
90299139
linkType: hard
90309140

9031-
"source-map@npm:^0.6.0, source-map@npm:^0.6.1, source-map@npm:~0.6.0, source-map@npm:~0.6.1":
9141+
"source-map@npm:^0.6.0, source-map@npm:^0.6.1, source-map@npm:~0.6.1":
90329142
version: 0.6.1
90339143
resolution: "source-map@npm:0.6.1"
90349144
checksum: 10c0/ab55398007c5e5532957cb0beee2368529618ac0ab372d789806f5718123cc4367d57de3904b4e6a4170eb5a0b0f41373066d02ca0735a0c4d75c7d328d3e011

0 commit comments

Comments
 (0)