Commit 8b14f3a
[Security Solution] fix page filters not working when newDataViewPickerEnabled ff is on (elastic#234124)
## Summary
This PR fixes a small issue introduced by the merge of this alerts page
refactor [PR](elastic#222457) and this
other [PR](elastic#227422) preparing for
the `newDataViewPickerEnabled` to be turned on.
With the alerts page refactor, we were now checking for the dataView to
be in `pristine` status, but we should have checked for `ready` status.
I noticed that we can have a dataView in `pristine` status while still
have its `id`, `title` and all its other fields being `undefined`...
Also, to avoid a split second of a error message being displayed, we're
now checking both `loading` and `pristine` statuses to show the loading
skeleton on the page.
| Before fix | After fix |
| ------------- | ------------- |
| <img width="932" height="633" alt="Screenshot 2025-09-05 at 9 01
01 AM"
src="https://github.com/user-attachments/assets/2d2d40d8-2b12-4e0c-828c-752e5c9757de"
/> | <img width="936" height="596" alt="Screenshot 2025-09-05 at 9 00
09 AM"
src="https://github.com/user-attachments/assets/ac803b70-d1dc-4c9a-9ad6-d0fa458479fc"
/> |
### How to test
- generate some alerts
- turn on the `newDataViewPickerEnabled` feature flag
### Checklist
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.1 parent b2f3748 commit 8b14f3a
File tree
2 files changed
+48
-5
lines changed- x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts
2 files changed
+48
-5
lines changedLines changed: 39 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
138 | 153 | | |
139 | 154 | | |
140 | 155 | | |
| |||
167 | 182 | | |
168 | 183 | | |
169 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
170 | 207 | | |
171 | 208 | | |
172 | 209 | | |
173 | 210 | | |
174 | 211 | | |
175 | 212 | | |
176 | 213 | | |
| 214 | + | |
177 | 215 | | |
178 | 216 | | |
179 | 217 | | |
| |||
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
74 | | - | |
| 73 | + | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
0 commit comments