Account for complex args to Complex

Author: Kodiologist

NEWS.rst

@@ -16,6 +16,7 @@ Bug Fixes
   `(except [] …)`, which catches all exceptions.
 * `(except [e []] …)` is now translated to Python correctly by `hy2py`.
 * Fixed a bug where logical ops starting with a `(setv …)` expression failed to compile.
+* A complex `imag` argument to `hy.models.Complex` is no longer allowed.
 
 1.0.0 ("Afternoon Review", released 2024-09-22)
 ======================================================================

hy/models.py

@@ -343,7 +343,10 @@ def __new__(cls, num, *args, **kwargs):
 
 class Complex(Object, complex):
     """
-    Represents a literal floating-point complex number (:class:`complex`).
+    Represents a literal floating-point complex number (:class:`complex`). If
+    ``real`` is itself a :class:`complex` object, its imaginary part is extracted and
+    added to the imaginary part of the new model, but ``imag``, if provided, must be
+    real.
     """
 
     def __new__(cls, real, imag=0, *args, **kwargs):
@@ -354,6 +357,12 @@ def __new__(cls, real, imag=0, *args, **kwargs):
             if p2:
                 check_inf_nan_cap(p2, value.imag)
             return value
+        if isinstance(imag, complex):
+            raise TypeError("`imag` must be real")
+        if isinstance(real, complex):
+            # This is deprecated by Python 3.14's `complex`, so
+            # extract the imaginary part before passing through.
+            real, imag = real.real, imag + real.imag
         return super().__new__(cls, real, imag)