feat: implement WalletConnect Sign-API #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borngraced
changed the title
borngraced
changed the title
laruh
reviewed
Sep 19, 2024
Comment on lines
+124
to
+125
| .name("namespace") | ||
| .expect("chain namespace name is missing: unexpected error") |
There was a problem hiding this comment.
shouldn't we handle error here instead of panic?
Collaborator
Author
|
closing in favor of KomodoPlatform/komodo-defi-framework#2223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WalletConnect Sign-API heavily inspired by reown-com#48 with refactoring, deduplication and code organization.
I will add more unit test and proceed to implement Core Pairing API.
Due Diligence