Merge pull request #177 from Kong/fix-middleware-bug

fix bug in middleware

Author: jackkav

README.md

@@ -15,6 +15,7 @@ Insomnia Mockbin is maintained by [Kong](https://github.com/Kong), who also main
   - [Running with Docker Compose](#running-with-docker-compose)
   - [Documentation](#documentation)
     - [API Docs](#api-docs)
+  - [Releasing](#releasing)
     - [Software Bill of materials](#software-bill-of-materials)
     - [Verify a container image signature](#verify-a-container-image-signature)
     - [Verify a container image provenance](#verify-a-container-image-provenance)
@@ -77,6 +78,16 @@ docker compose up
 
 Read the full API documentation, please review the [API Docs](https://github.com/Kong/mockbin/tree/master/docs).
 
+## Releasing
+
+Run the following command and push the newly created commit into your PR.
+This will bump commit and tag, you will need to push this to the remote, which trigger the release action upon merging the PR.
+
+```sh
+npm version patch
+git push origin tag <tag_name>
+```
+
 ### Software Bill of materials
 
 Kong Insomnia Mockbin produces SBOMs for the below categories:

lib/index.js

@@ -6,14 +6,6 @@ const routes = require("./routes");
 module.exports = function (options) {
 	const router = express.Router();
 
-	const defaults = [
-		mw.errorHandler,
-		mw.bodyParser,
-		mw.cors,
-		mw.poweredBy,
-		mw.negotiateContent,
-	];
-
 	const endpoints = [
 		{ action: "get", path: "/", route: routes.hello },
 		{ action: "all", path: "/ip", route: routes.ips.one },
@@ -38,11 +30,18 @@ module.exports = function (options) {
 	];
 
 	endpoints.forEach((endpoint) => {
-		// add route to middleware
-		defaults.splice(3, 1, endpoint.route);
-
 		// assign router to action at path
-		router[endpoint.action].apply(router, [endpoint.path].concat(defaults));
+		router[endpoint.action].apply(
+			router,
+			[endpoint.path].concat([
+				mw.errorHandler,
+				mw.bodyParser,
+				endpoint.route,
+				mw.cors,
+				mw.poweredBy,
+				mw.negotiateContent,
+			]),
+		);
 	});
 
 	if (options?.redis) {

lib/routes/bins.js

@@ -29,14 +29,6 @@ module.exports = function bins(dsnStr) {
 
 	const router = express.Router();
 
-	const defaults = [
-		mw.errorHandler,
-		mw.bodyParser,
-		null,
-		mw.cors,
-		mw.negotiateContent,
-	];
-
 	const endpoints = [
 		{ action: "get", path: "/create", route: routes.form },
 		{
@@ -69,11 +61,17 @@ module.exports = function bins(dsnStr) {
 	];
 
 	endpoints.forEach((endpoint) => {
-		// add route to middleware
-		defaults.splice(3, 1, endpoint.route);
-
 		// assign router to action at path
-		router[endpoint.action].apply(router, [endpoint.path].concat(defaults));
+		router[endpoint.action].apply(
+			router,
+			[endpoint.path].concat([
+				mw.errorHandler,
+				mw.bodyParser,
+				endpoint.route,
+				mw.cors,
+				mw.negotiateContent,
+			]),
+		);
 	});
 
 	return router;

package-lock.json

@@ -1,5 +1,5 @@
 {
-	"version": "2.0.1",
+	"version": "2.0.2",
 	"name": "mockbin",
 	"description": "Test, mock, and track HTTP requests & responses between libraries, sockets and APIs",
 	"author": "Kong (https://www.konghq.com/)",