fix: fix KongPlugin watch functions (#3186)

Author: pmalek

controller/konnect/watch.go

@@ -132,11 +132,12 @@ func objectListToReconcileRequests[
 	}
 
 	ret := make([]ctrl.Request, 0, len(items))
+itemLoop:
 	for _, item := range items {
 		var e TPtr = &item
 		for _, filter := range filters {
 			if filter != nil && !filter(e) {
-				continue
+				continue itemLoop
 			}
 		}
 		ret = append(ret, ctrl.Request{

controller/konnect/watch_kongplugin.go

@@ -71,10 +71,16 @@ func (r *KongPluginReconciler) mapKongPluginBindings(ctx context.Context, obj cl
 		return []ctrl.Request{}
 	}
 
+	ns := kongPluginBinding.Namespace
+	pluginRef := kongPluginBinding.Spec.PluginReference
+	if pluginRef.Namespace != "" && pluginRef.Namespace != ns {
+		ns = pluginRef.Namespace
+	}
+
 	return []ctrl.Request{
 		{
 			NamespacedName: types.NamespacedName{
-				Namespace: kongPluginBinding.Namespace,
+				Namespace: ns,
 				Name:      kongPluginBinding.Spec.PluginReference.Name,
 			},
 		},

controller/konnect/watch_kongpluginbinding.go

@@ -144,8 +144,6 @@ func enqueueKongPluginBindingForKongPlugin(cl client.Client) func(
 
 		pluginBindingList := configurationv1alpha1.KongPluginBindingList{}
 		err := cl.List(ctx, &pluginBindingList,
-			// Currently KongPlugin and KongPluginBinding must be in the same namespace to reference the plugin.
-			client.InNamespace(plugin.Namespace),
 			client.MatchingFields{
 				index.IndexFieldKongPluginBindingKongPluginReference: plugin.Namespace + "/" + plugin.Name,
 			},