chore(gen) use modern plugin schema API (#3116)

Remove the controller's plugin default population in favor of equivalent
functionality now provided by go-kong. The go-kong functionality uses
the modern GetFullSchema instead of the deprecated GetSchema.

Remove helpers and tests associated with the old KIC functionality.

Co-authored-by: Yi Tao <[email protected]>

Author: rainest

go.mod

@@ -27,7 +27,6 @@ require (
 	github.com/spf13/cobra v1.6.1
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.1
-	github.com/tidwall/gjson v1.14.3
 	golang.org/x/net v0.0.0-20221014081412-f15817d10f9b
 	google.golang.org/api v0.101.0
 	google.golang.org/genproto v0.0.0-20221018160656-63c7b68cfc55
@@ -140,6 +139,7 @@ require (
 	github.com/sergi/go-diff v1.2.0 // indirect
 	github.com/shirou/gopsutil/v3 v3.22.8 // indirect
 	github.com/ssgelm/cookiejarparser v1.0.1 // indirect
+	github.com/tidwall/gjson v1.14.3 // indirect
 	github.com/tidwall/match v1.1.1 // indirect
 	github.com/tidwall/pretty v1.2.0 // indirect
 	github.com/tklauser/go-sysconf v0.3.10 // indirect

internal/dataplane/deckgen/deckgen.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/kong/deck/file"
 	"github.com/kong/go-kong/kong"
-	"github.com/tidwall/gjson"
 )
 
 // GenerateSHA generates a SHA256 checksum of the (targetContent, customEntities) tuple, with the purpose of change
@@ -117,63 +116,3 @@ func PluginString(plugin file.FPlugin) string {
 	}
 	return result
 }
-
-// FillPluginConfig returns a copy of `config` that has default values filled in from `schema`.
-func FillPluginConfig(schema map[string]interface{},
-	config kong.Configuration,
-) (kong.Configuration, error) {
-	jsonb, err := json.Marshal(&schema)
-	if err != nil {
-		return nil, err
-	}
-	// Get all in the schema
-	value := gjson.ParseBytes((jsonb))
-	return fillRecord(value, config)
-}
-
-func fillRecord(schema gjson.Result, config kong.Configuration) (kong.Configuration, error) {
-	if config == nil {
-		return nil, nil
-	}
-	res := config.DeepCopy()
-	value := schema.Get("fields")
-
-	value.ForEach(func(key, value gjson.Result) bool {
-		// get the key name
-		ms := value.Map()
-		fname := ""
-		for k := range ms {
-			fname = k
-			break
-		}
-		ftype := value.Get(fname + ".type")
-		if ftype.String() == "record" {
-			subConfig := config[fname]
-			if subConfig == nil {
-				subConfig = make(map[string]interface{})
-			}
-			newSubConfig, err := fillRecord(value.Get(fname), subConfig.(map[string]interface{}))
-			if err != nil {
-				panic(err)
-			}
-			res[fname] = map[string]interface{}(newSubConfig)
-			return true
-		}
-		// check if key is already set in the config
-		if _, ok := config[fname]; ok {
-			// yes, don't set it
-			return true
-		}
-		// no, set it
-		value = value.Get(fname + ".default")
-		if value.Exists() {
-			res[fname] = value.Value()
-		} else {
-			// if no default exists, set an explicit nil
-			res[fname] = nil
-		}
-		return true
-	})
-
-	return res, nil
-}