fix: rework build and publish [INS-1051] (#95)

balugeorge · web-flow · commit e7c1e4554581 · 2025-08-12T13:08:05.000+05:30
* Trigger build on push to any branch

* Publish binary without tag verification

* Move release binary publishing to a gitHub actions workflow

* Remove cleanup from build script

* Fix token

* Debugging failure

* Fetch all history for all tags and branches on build

* Hardcode release version for testing

* Cleanup

* More debugging

* Fix packaging

* More debugging

* Move packaging back to build script; upload both arm64 and x64 Mac binaries

* Hardcode electron version

* More fixes

* Fix publish for all binaries

* Ignore existing binaries instead of overwriting them

* Add missing token reference

* Disable builds temporarily for existing release binaries

* Ignore errors if a release binary exists

* Skip conditional for windows build and disable all other builds

* Fix typo

* Fix publish binary command for windows

* Only publish binaries when a tag exists

* Replace hardcoded release version with current tag

* Fail stage if a release build exists

* Trigger builds only when a tag is added or when pushing to the develop branch

* Create a draft release by triggering the version workflow on push

* Fix default value for version input

* Create the release without pushing a new tag

* Fix default for version value

* Bump default version

* Fix tag and version

* Cleanup

* Bump tag and version

* Switch to automated release on tag creation

* Bump electron version to 37.x

* Bump node-libcurl version to 3.0.0

* Disable creation of reelase version on push
diff --git a/.electron-version b/.electron-version
@@ -1 +1 @@
-36.4.0
+37.2.6
diff --git a/.github/workflows/build-and-release.yaml b/.github/workflows/build-and-release.yaml
@@ -15,6 +15,27 @@ on:
 # all jobs here must have a matrix identical to the ones inside build-lint-test.yaml
 
 jobs:
+  release:
+    permissions: write-all
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Create Tag and Release
+        if: startsWith(github.ref, 'refs/tags/')
+        uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1
+        id: core_tag_and_release
+        with:
+          tag: v${{ env.TAG }}
+          name: 'nodelibcurl v${{ env.TAG }} 📦'
+          generateReleaseNotes: true
+          prerelease: false
+          draft: true
+
   scan:
     permissions:
       packages: write
@@ -25,6 +46,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           path: ${{ github.repository }}
+          # fetch-depth: 0
 
       # Perform SCA analysis for the code repository
       # Produces SBOM and CVE report
@@ -110,13 +132,34 @@ jobs:
       - name: 'Set GIT_TAG'
         if: startsWith(github.ref, 'refs/tags')
         run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-      - name: 'Publish Binary'
+      - name: 'Build Binary'
         run: |
           pip install packaging
           GIT_COMMIT=${{ github.sha }} \
           GIT_TAG=$GIT_TAG \
           RUNNER_OS=${{ matrix.os }} \
           ./scripts/ci/build.sh
+      - name: 'Publish Binary'
+        if: runner.os != 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: 'Publish x64 Mac Binary'
+        if: runner.os == 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package_x64.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: 'Publish arm64 Mac Binary'
+        if: runner.os == 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package_arm64.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Upload artifacts
         if: always()
         uses: actions/upload-artifact@v4
@@ -178,12 +221,33 @@ jobs:
       - name: 'Set GIT_TAG'
         if: startsWith(github.ref, 'refs/tags')
         run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-      - name: 'Publish Binary'
+      - name: 'Build Binary'
         run: |
           pip install packaging
           GIT_COMMIT=${{ github.sha }} \
           GIT_TAG=$GIT_TAG \
           ./scripts/ci/build.sh
+      - name: 'Publish Binary'
+        if: runner.os != 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: 'Publish x64 Mac Binary'
+        if: runner.os == 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package_x64.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: 'Publish arm64 Mac Binary'
+        if: runner.os == 'macOS' && startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) \
+          "$(cat ./package_arm64.txt)"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Upload artifacts
         if: always()
         uses: actions/upload-artifact@v4
@@ -229,12 +293,18 @@ jobs:
           if ($LASTEXITCODE -eq 0) {
             $host.SetShouldExit(0)
           }
-      - name: Publish binary
+      - name: Build binary
         if: startsWith(github.ref, 'refs/tags/')
         run: |
           pip install packaging
           npm run pregyp package testpackage --verbose
-          node scripts\module-packaging.js --publish $(npm run -s pregyp reveal staged_tarball --silent)
+          # node scripts\module-packaging.js --publish $(npm run -s pregyp reveal staged_tarball --silent)
+      - name: Publish Binary
+        if: startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) $(npm run -s pregyp reveal staged_tarball --silent)
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   build-and-release-electron-windows:
     needs: setup
@@ -277,9 +347,14 @@ jobs:
           if ($LASTEXITCODE -eq 0) {
             $host.SetShouldExit(0)
           }
-      - name: Publish binary
+      - name: Build binary
         if: startsWith(github.ref, 'refs/tags/')
         run: |
           pip install packaging
           npm run pregyp package testpackage --verbose
-          node scripts\module-packaging.js --publish $(npm run -s pregyp reveal staged_tarball --silent)
+      - name: Publish Binary
+        if: startsWith(github.ref, 'refs/tags/')
+        run: |
+          gh release upload $(git describe --exact-match --tags) $(npm run -s pregyp reveal staged_tarball --silent)
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/new-version.yml b/.github/workflows/new-version.yml
@@ -20,33 +20,33 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-          token: ${{ secrets.PAT_INSOMNIA_INFRA }}
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Configure Git user
         uses: Homebrew/actions/git-user-config@266845213695c3047d210b2e8fbc42ecdaf45802 # master
         with:
           username: ${{ (github.event_name == 'workflow_dispatch' && github.actor) || 'insomnia-infra' }}
 
-      - name: Setup Node
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: '.node-version'
+      # - name: Setup Node
+      #   uses: actions/setup-node@v4
+      #   with:
+      #     node-version-file: '.node-version'
 
-      - name: Install
-        run: npm ci --ignore-scripts
+      # - name: Install
+      #   run: npm ci --ignore-scripts
 
-      - name: Create new package version
-        run: npm version "${{ env.TAG }}"
+      # - name: Create new package version
+      #   run: npm version "${{ env.TAG }}"
 
       - name: DEBUG see tags
         run: |
           git tag --list
           git remote -v
 
-      - name: Merge version commit into develop
-        run: |
-          git push origin v${{ env.TAG }}
-          git push origin develop
+      # - name: Merge version commit into develop
+      #   run: |
+      #     git push origin v${{ env.TAG }}
+      #     git push origin develop
 
       - name: Create Tag and Release
         uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1
@@ -56,4 +56,4 @@ jobs:
           name: 'nodelibcurl v${{ env.TAG }} 📦'
           generateReleaseNotes: true
           prerelease: false
-          draft: false
+          draft: true
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@getinsomnia/node-libcurl",
-  "version": "2.36.12",
+  "version": "3.0.0",
   "description": "The fastest http(s) client (and much more) for Node.js - Node.js bindings for libcurl",
   "keywords": [
     "node-curl",
diff --git a/scripts/ci/build.sh b/scripts/ci/build.sh
@@ -373,45 +373,52 @@ if [ "$RUN_TESTS" == "true" ]; then
   fi
 fi
 
+echo "=== node version: $(node -v)"
+
 # If we are here, it means the addon worked
 # Check if we need to publish the binaries
 if [[ $PUBLISH_BINARY == true && $LIBCURL_RELEASE == $LATEST_LIBCURL_RELEASE ]]; then
   echo "=== Publish binary is true - Testing and publishing package with pregyp"
   if [[ "$MACOS_UNIVERSAL_BUILD" == "true" ]]; then
     # Need to publish two binaries when doing a universal build.
     # --
-    # Publish x64 package
+    # Build x64 package
     npm_config_target_arch=x64 npm run pregyp package testpackage --verbose
-    npm_config_target_arch=x64 node scripts/module-packaging.js --publish \
-      "$(npm_config_target_arch=x64 npm run --silent pregyp reveal staged_tarball --silent)"
-    # Publish arm64 package.
+    npm_config_target_arch=x64 npm run --silent pregyp reveal staged_tarball --silent>package_x64.txt
+    # npm_config_target_arch=x64 node scripts/module-packaging.js --publish \
+    #   "$(npm_config_target_arch=x64 npm run --silent pregyp reveal staged_tarball --silent)"
+    # Build arm64 package.
     npm_config_target_arch=arm64 npm run pregyp package --verbose  # Can't testpackage for arm64 yet.
-    npm_config_target_arch=arm64 node scripts/module-packaging.js --publish \
-      "$(npm_config_target_arch=arm64 npm run --silent pregyp reveal staged_tarball --silent)"
+    npm_config_target_arch=arm64 npm run --silent pregyp reveal staged_tarball --silent>package_arm64.txt
+    # npm_config_target_arch=arm64 node scripts/module-packaging.js --publish \
+    #   "$(npm_config_target_arch=arm64 npm run --silent pregyp reveal staged_tarball --silent)"
   else
     npm run pregyp package testpackage --verbose
-    node scripts/module-packaging.js --publish "$(npm run --silent pregyp reveal staged_tarball --silent)"
+    npm run --silent pregyp reveal staged_tarball --silent>package.txt
+    # node scripts/module-packaging.js --publish "$(npm run --silent pregyp reveal staged_tarball --silent)"
   fi
 fi
-echo "=== node version: $(node -v)"
-# In case we published the binaries, verify if we can download them, and that they work
-# Otherwise, unpublish them
-INSTALL_RESULT=0
-if [[ $PUBLISH_BINARY == true ]]; then
-  echo "=== Publish binary is true - Testing if it was published correctly"
 
-  INSTALL_RESULT=$(npm_config_fallback_to_build=false npm ci > /dev/null)$? || true
-fi
-if [[ $INSTALL_RESULT != 0 ]]; then
-  echo "=== Failed to install package from npm after being published"
-  node scripts/module-packaging.js --unpublish "$(npm run --silent pregyp reveal hosted_tarball --silent)"
-  false
-fi
+## Move this to action or a different script later
+# echo "=== node version: $(node -v)"
+# # In case we published the binaries, verify if we can download them, and that they work
+# # Otherwise, unpublish them
+# INSTALL_RESULT=0
+# if [[ $PUBLISH_BINARY == true ]]; then
+#   echo "=== Publish binary is true - Testing if it was published correctly"
 
-# Clean everything
-if [[ $RUN_PREGYP_CLEAN == true ]]; then
-  echo "=== cleanup"
-  npm run pregyp clean
-fi
+#   INSTALL_RESULT=$(npm_config_fallback_to_build=false npm ci > /dev/null)$? || true
+# fi
+# if [[ $INSTALL_RESULT != 0 ]]; then
+#   echo "=== Failed to install package from npm after being published"
+#   node scripts/module-packaging.js --unpublish "$(npm run --silent pregyp reveal hosted_tarball --silent)"
+#   false
+# fi
+
+# # Clean everything
+# if [[ $RUN_PREGYP_CLEAN == true ]]; then
+#   echo "=== cleanup"
+#   npm run pregyp clean
+# fi
 
 set +uv

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@getinsomnia/node-libcurl",`
`3`		`- "version": "2.36.12",`
	`3`	`+ "version": "3.0.0",`
`4`	`4`	`"description": "The fastest http(s) client (and much more) for Node.js - Node.js bindings for libcurl",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"node-curl",`