Skip to content

Commit 8e5385f

Browse files
committed
more SSE tests
1 parent dcb8950 commit 8e5385f

File tree

5 files changed

+35
-2
lines changed

5 files changed

+35
-2
lines changed

unirest-bdd-tests/src/test/java/BehaviorTests/MockServer.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,14 @@ public static void sendEvent(String content) {
402402
TestSSEConsumer.sendEvent(content);
403403
}
404404

405+
public static void sendEvent(String id, String event, String content) {
406+
TestSSEConsumer.sendEvent(id, event, content);
407+
}
408+
409+
public static void sendEvent(String event, String content) {
410+
TestSSEConsumer.sendEvent(event, content);
411+
}
412+
405413
public static RequestCapture lastRequest() {
406414
return TestSSEConsumer.getLastRequest();
407415
}

unirest-bdd-tests/src/test/java/BehaviorTests/SSETest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,19 @@ void basicConnection() {
6262
.assertHasEvent("message", "Whats Happening?");
6363
}
6464

65+
@Test
66+
void eventsWithIds() {
67+
runWith(sse(MockServer.SSE), listener);
68+
69+
MockServer.Sse.sendEvent("123", "cheese", "cheddar");
70+
MockServer.Sse.sendEvent( "cheese", "gouda");
71+
72+
sleep(500);
73+
74+
listener.assertHasEvent("123", "cheese", "cheddar")
75+
.assertHasEvent("cheese", "gouda");
76+
}
77+
6578
@Test
6679
void queryParams(){
6780
runWith(sse(MockServer.SSE)

unirest-bdd-tests/src/test/java/BehaviorTests/TestListener.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,12 @@ TestListener assertHasComment(String comment) {
4545
}
4646

4747
public TestListener assertHasEvent(String event, String content) {
48+
return assertHasEvent("", event, content);
49+
}
50+
51+
public TestListener assertHasEvent(String id, String event, String content) {
4852
assertThat(events)
49-
.contains(new Event("", event, content));
53+
.contains(new Event(id, event, content));
5054
return this;
5155
}
5256

unirest-bdd-tests/src/test/java/BehaviorTests/TestSSEConsumer.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,14 @@ public static void sendEvent(String data) {
4747
clients.forEach(c -> c.sendEvent(data));
4848
}
4949

50+
public static void sendEvent(String id, String event, String content) {
51+
clients.forEach(c -> c.sendEvent(event, content, id));
52+
}
53+
54+
public static void sendEvent(String event, String content) {
55+
clients.forEach(c -> c.sendEvent(event, content));
56+
}
57+
5058
@Override
5159
public void accept(SseClient client) {
5260
lastRequest = new RequestCapture(client.ctx());

unirest/src/main/java/kong/unirest/core/SseRequestImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class SseRequestImpl implements SseRequest {
3838

3939
public SseRequestImpl(Config config, String url) {
4040
Objects.requireNonNull(config, "Config cannot be null");
41-
Objects.requireNonNull(url, "URL cannot be null");
41+
Objects.requireNonNull(url, "URL cannot be null");
4242

4343
this.config = config;
4444
this.url = new Path(url, config.getDefaultBaseUrl());

0 commit comments

Comments
 (0)