Closing the response InputStream

[gtaylor1981]

Should I close the response InputStream in the asObject callback?

e.g.

this.unirest.get(url).asObject(r -> {
  try (final InputStream is = r.getContent()) {
    return download(is);
  }
});

[ryber]

When you do a "try with resource" as you have done here the try will automatically close the resource as long as it implements Closeable (which InputStream does). This is effectively done in a magical finally block

[gtaylor1981]

Thanks for the reply. At the moment I do not use the "try with resource" though.
My current code is more like: this.unirest.get(url).asObject(r -> download(r.getContent()));

Should I be closing the stream? Is is safe/recommended? It worked when I tried it at least but I was not sure if it might be needed later.

[ryber]

Yes it is always best practice to close a InputStream or else resources could be left hanging.